* [PATCH] s390: crypto: add select CRYPTO_AEAD for aes
@ 2026-05-20 7:38 Arnd Bergmann
2026-05-20 7:47 ` Harald Freudenberger
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-05-20 7:38 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Harald Freudenberger, Holger Dengler,
Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Patrick Steuer
Cc: Arnd Bergmann, Christian Borntraeger, Sven Schnelle, Eric Biggers,
Ard Biesheuvel, linux-crypto, linux-s390, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The aes driver registers both skcipher and aead algorithms,
but when aead is not enabled this causes a link failure:
s390-linux-ld: arch/s390/crypto/aes_s390.o: in function `aes_s390_fini':
arch/s390/crypto/aes_s390.c:969:(.text+0x115e): undefined reference to `crypto_unregister_aead'
s390-linux-ld: arch/s390/crypto/aes_s390.o: in function `aes_s390_init':
arch/s390/crypto/aes_s390.c:1028:(.init.text+0x294): undefined reference to `crypto_register_aead'
Add the missing 'select' statement.
Fixes: bf7fa038707c ("s390/crypto: add s390 platform specific aes gcm support.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/s390/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/s390/crypto/Kconfig b/arch/s390/crypto/Kconfig
index 00051d27db95..228570a1b233 100644
--- a/arch/s390/crypto/Kconfig
+++ b/arch/s390/crypto/Kconfig
@@ -4,6 +4,7 @@ menu "Accelerated Cryptographic Algorithms for CPU (s390)"
config CRYPTO_AES_S390
tristate "Ciphers: AES, modes: ECB, CBC, CTR, XTS, GCM"
+ select CRYPTO_AEAD
select CRYPTO_SKCIPHER
help
AEAD cipher: AES with GCM
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390: crypto: add select CRYPTO_AEAD for aes
2026-05-20 7:38 [PATCH] s390: crypto: add select CRYPTO_AEAD for aes Arnd Bergmann
@ 2026-05-20 7:47 ` Harald Freudenberger
0 siblings, 0 replies; 2+ messages in thread
From: Harald Freudenberger @ 2026-05-20 7:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Herbert Xu, David S. Miller, Holger Dengler, Heiko Carstens,
Vasily Gorbik, Alexander Gordeev, Patrick Steuer, Arnd Bergmann,
Christian Borntraeger, Sven Schnelle, Eric Biggers,
Ard Biesheuvel, linux-crypto, linux-s390, linux-kernel
On 2026-05-20 09:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The aes driver registers both skcipher and aead algorithms,
> but when aead is not enabled this causes a link failure:
>
> s390-linux-ld: arch/s390/crypto/aes_s390.o: in function
> `aes_s390_fini':
> arch/s390/crypto/aes_s390.c:969:(.text+0x115e): undefined reference to
> `crypto_unregister_aead'
> s390-linux-ld: arch/s390/crypto/aes_s390.o: in function
> `aes_s390_init':
> arch/s390/crypto/aes_s390.c:1028:(.init.text+0x294): undefined
> reference to `crypto_register_aead'
>
> Add the missing 'select' statement.
>
> Fixes: bf7fa038707c ("s390/crypto: add s390 platform specific aes gcm
> support.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/s390/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/s390/crypto/Kconfig b/arch/s390/crypto/Kconfig
> index 00051d27db95..228570a1b233 100644
> --- a/arch/s390/crypto/Kconfig
> +++ b/arch/s390/crypto/Kconfig
> @@ -4,6 +4,7 @@ menu "Accelerated Cryptographic Algorithms for CPU
> (s390)"
>
> config CRYPTO_AES_S390
> tristate "Ciphers: AES, modes: ECB, CBC, CTR, XTS, GCM"
> + select CRYPTO_AEAD
> select CRYPTO_SKCIPHER
> help
> AEAD cipher: AES with GCM
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-20 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-20 7:38 [PATCH] s390: crypto: add select CRYPTO_AEAD for aes Arnd Bergmann
2026-05-20 7:47 ` Harald Freudenberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox