From: Milan Broz <gmazyland@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [v3 PATCH] crypto: wp512 - Use API partial block handling
Date: Fri, 20 Jun 2025 15:22:57 +0200 [thread overview]
Message-ID: <6a5313ca-4b57-4688-81c1-692e49c689a7@gmail.com> (raw)
In-Reply-To: <aFVQx1iDdBnaJ9sa@gondor.apana.org.au>
On 6/20/25 2:15 PM, Herbert Xu wrote:
> On Fri, Jun 20, 2025 at 10:52:49AM +0200, Milan Broz wrote:
>>
>> It s still failing for me for that userspace crypt API.
>
> OK I screwed up the final marker. The old code always left a
> zero byte in the buffer so the finalisation could simply or it
> with 0x80. With the new code, we need to set it to 0x80 explicitly
> instead of oring.
>
> ---8<---
> Use the Crypto API partial block handling.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Yes, we have a winner ;-) It works now, thanks!
Tested-by: Milan Broz <gmazyland@gmail.com>
I guess this will go to the next crypto update pull request.
Thanks,
Milan
next prev parent reply other threads:[~2025-06-20 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 21:18 Failure in HMAC with Whirlpool hash in 6.16-rc2 Milan Broz
2025-06-20 4:19 ` Herbert Xu
2025-06-20 5:47 ` [PATCH] crypto: wp512 - Use API partial block handling Herbert Xu
2025-06-20 8:10 ` Milan Broz
2025-06-20 8:37 ` [v2 PATCH] " Herbert Xu
2025-06-20 8:52 ` Milan Broz
2025-06-20 12:15 ` [v3 " Herbert Xu
2025-06-20 13:22 ` Milan Broz [this message]
2025-06-21 3:06 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a5313ca-4b57-4688-81c1-692e49c689a7@gmail.com \
--to=gmazyland@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox