public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Failure in HMAC with Whirlpool hash in 6.16-rc2
Date: Thu, 19 Jun 2025 23:18:13 +0200	[thread overview]
Message-ID: <8be28417-2733-4494-8a09-b4343a3bcf3d@gmail.com> (raw)

Hi Herbert,

another regression in kernel 6.16-rc2, this time in AF_ALF for Whirlpool hash.

Cryptsetup can use kernel userspace API instead of userspace crypto lib and we
have some testvectors to detect breakage of crypto.

It now fails with PBKDF with Whirlpool hash (HMAC).

You can reproduce it compiling cryptsetup with kernel API backend and run vector test:
./autogen.sh
./configure --with-crypto_backend=kernel
make check-programs
tests/vectors-test
...

PBKDF vector 17 pbkdf2-sha1 [OK]
PBKDF vector 18 pbkdf2-sha256 [OK]
PBKDF vector 19 pbkdf2-sha512 [OK]
PBKDF vector 20 pbkdf2-whirlpool [API FAILED]
PBKDF test failed.

The bisect points to

Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Thu May 15 13:54:42 2025 +0800

     crypto: hmac - Add export_core and import_core

     Add export_import and import_core so that hmac can be used as a
     fallback by block-only drivers.

Please let me know if you need more info.
Milan


             reply	other threads:[~2025-06-19 21:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19 21:18 Milan Broz [this message]
2025-06-20  4:19 ` Failure in HMAC with Whirlpool hash in 6.16-rc2 Herbert Xu
2025-06-20  5:47 ` [PATCH] crypto: wp512 - Use API partial block handling Herbert Xu
2025-06-20  8:10   ` Milan Broz
2025-06-20  8:37     ` [v2 PATCH] " Herbert Xu
2025-06-20  8:52       ` Milan Broz
2025-06-20 12:15         ` [v3 " Herbert Xu
2025-06-20 13:22           ` Milan Broz
2025-06-21  3:06             ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8be28417-2733-4494-8a09-b4343a3bcf3d@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox