Re: [PATCH] crypto: wp512 - Use API partial block handling

[Milan Broz <gmazyland@gmail.com>]

On 6/20/25 7:47 AM, Herbert Xu wrote:
> On Thu, Jun 19, 2025 at 11:18:13PM +0200, Milan Broz wrote:
>>
>> The bisect points to
>>
>> Author: Herbert Xu <herbert@gondor.apana.org.au>
>> Date:   Thu May 15 13:54:42 2025 +0800
>>
>>      crypto: hmac - Add export_core and import_core
>>
>>      Add export_import and import_core so that hmac can be used as a
>>      fallback by block-only drivers.
>>
>> Please let me know if you need more info.
> 
> Please try this patch:
> 
> ---8<---
> Use the Crypto API partial block handling.
>      
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Hi,

Now I get wrong data instead of fail (both on 32bit and 64bit).
Patch just applied over today's Linus' tree

...
PBKDF vector 20 pbkdf2-whirlpool [FAILED]
  got:  58 55 1e ef 29 40 d6 a2 f0 59 e0 d9 4a 50 c5 df 01 25 be ee 27 5b 35 47 6d 37 38 13 0f e0 da 29
want:  9c 1c 74 f5 88 26 e7 6a 53 58 f4 0c 39 e7 80 89 07 c0 31 19 9a 50 a2 48 f1 d9 fe 78 64 e5 84 50
PBKDF test failed.

(Whirlpool is translated to wp512 in the crypto backend and despite it is a quite rare use, some people
used if for LUKS PBKDF2. Actually the whole vector test was reaction to wrong Whirlpool implementation
in gcrypt years ago. It apparently can find breakage even today :-)

Milan