public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
* Re: qcom-rng is broken for acpi
@ 2024-09-06 20:33 Sam Bingner
  0 siblings, 0 replies; 13+ messages in thread
From: Sam Bingner @ 2024-09-06 20:33 UTC (permalink / raw)
  To: 'Brian Masney', 'Jeffrey Hugo'
  Cc: '"Ernesto A. Fernández"',
	'Trilok Soni', 'linux-crypto@vger.kernel.org',
	'Herbert Xu', 'David S. Miller',
	'linux-arm-msm@vger.kernel.org',
	'"Om Prakash Singh"'

Brian,

Yes we do see those same errors on our Amberwing systems. 

New Kernel (6.8.0-40-generic from ubuntu):
[    4.300484] arm-smmu-v3 arm-smmu-v3.0.auto: option mask 0x0
[    4.305192] arm-smmu-v3 arm-smmu-v3.0.auto: ias 44-bit, oas 44-bit (features 0x000a1fef)
[    4.313588] arm-smmu-v3 arm-smmu-v3.0.auto: allocated 65536 entries for cmdq
[    4.320528] arm-smmu-v3 arm-smmu-v3.0.auto: allocated 32768 entries for evtq
[    4.327273] arm-smmu-v3 arm-smmu-v3.0.auto: SMMU currently enabled! Resetting...
[    4.335000] arm-smmu-v3 arm-smmu-v3.5.auto: option mask 0x0
[    4.340207] arm-smmu-v3 arm-smmu-v3.5.auto: ias 44-bit, oas 44-bit (features 0x000a1fef)
[    4.348569] arm-smmu-v3 arm-smmu-v3.5.auto: allocated 65536 entries for cmdq
[    4.355559] arm-smmu-v3 arm-smmu-v3.5.auto: allocated 32768 entries for evtq
[    4.362344] arm-smmu-v3 arm-smmu-v3.5.auto: SMMU currently enabled! Resetting...
[    4.370023] arm-smmu-v3 arm-smmu-v3.10.auto: option mask 0x0
[    4.375362] arm-smmu-v3 arm-smmu-v3.10.auto: ias 44-bit, oas 44-bit (features 0x000a1fef)
[    4.383824] arm-smmu-v3 arm-smmu-v3.10.auto: allocated 65536 entries for cmdq
[    4.390895] arm-smmu-v3 arm-smmu-v3.10.auto: allocated 32768 entries for evtq
[    4.397756] arm-smmu-v3 arm-smmu-v3.10.auto: SMMU currently enabled! Resetting...
[    4.405534] arm-smmu-v3 arm-smmu-v3.15.auto: option mask 0x0
[    4.410866] arm-smmu-v3 arm-smmu-v3.15.auto: ias 44-bit, oas 44-bit (features 0x000a1fef)
[    4.419358] arm-smmu-v3 arm-smmu-v3.15.auto: allocated 65536 entries for cmdq
[    4.426416] arm-smmu-v3 arm-smmu-v3.15.auto: allocated 32768 entries for evtq
[    4.433259] arm-smmu-v3 arm-smmu-v3.15.auto: SMMU currently enabled! Resetting...
[    4.441033] arm-smmu-v3 arm-smmu-v3.20.auto: option mask 0x0
[    4.446369] arm-smmu-v3 arm-smmu-v3.20.auto: ias 44-bit, oas 44-bit (features 0x000a1fef)
[    4.454497] cma: cma_alloc: reserved: alloc failed, req-size: 256 pages, ret: -12
[    4.462002] arm-smmu-v3 arm-smmu-v3.20.auto: allocated 65536 entries for cmdq
[    4.469088] cma: cma_alloc: reserved: alloc failed, req-size: 256 pages, ret: -12
[    4.476587] arm-smmu-v3 arm-smmu-v3.20.auto: allocated 32768 entries for evtq
[    4.483695] arm-smmu-v3 arm-smmu-v3.20.auto: SMMU currently enabled! Resetting...
[    4.491482] arm-smmu-v3 arm-smmu-v3.25.auto: option mask 0x0
[    4.496808] arm-smmu-v3 arm-smmu-v3.25.auto: ias 44-bit, oas 44-bit (features 0x000a1fef)
[    4.504931] cma: cma_alloc: reserved: alloc failed, req-size: 256 pages, ret: -12
[    4.512433] arm-smmu-v3 arm-smmu-v3.25.auto: allocated 65536 entries for cmdq
[    4.519526] cma: cma_alloc: reserved: alloc failed, req-size: 256 pages, ret: -12
[    4.527021] arm-smmu-v3 arm-smmu-v3.25.auto: allocated 32768 entries for evtq
[    4.534123] arm-smmu-v3 arm-smmu-v3.25.auto: SMMU currently enabled! Resetting...
...
[   12.199744] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.1.auto: invalid resource (null)
[   12.199751] arm-smmu-v3-pmcg: probe of arm-smmu-v3-pmcg.1.auto failed with error -22

Repeats for 1->29

Old Kernel (5.3.18):
[    5.154003] arm-smmu-v3 arm-smmu-v3.0.auto: option mask 0x0
[    5.158928] arm-smmu-v3 arm-smmu-v3.0.auto: ias 44-bit, oas 44-bit (features 0x00001fcf)
[    5.167128] arm-smmu-v3 arm-smmu-v3.0.auto: allocated 65536 entries for cmdq
[    5.174125] arm-smmu-v3 arm-smmu-v3.0.auto: allocated 32768 entries for evtq
[    5.181041] arm-smmu-v3 arm-smmu-v3.0.auto: SMMU currently enabled! Resetting...
[    5.188718] arm-smmu-v3 arm-smmu-v3.5.auto: option mask 0x0
[    5.193990] arm-smmu-v3 arm-smmu-v3.5.auto: ias 44-bit, oas 44-bit (features 0x00001fcf)
[    5.202107] arm-smmu-v3 arm-smmu-v3.5.auto: allocated 65536 entries for cmdq
[    5.209311] arm-smmu-v3 arm-smmu-v3.5.auto: allocated 32768 entries for evtq
[    5.216108] arm-smmu-v3 arm-smmu-v3.5.auto: SMMU currently enabled! Resetting...
[    5.223643] arm-smmu-v3 arm-smmu-v3.10.auto: option mask 0x0
[    5.229146] arm-smmu-v3 arm-smmu-v3.10.auto: ias 44-bit, oas 44-bit (features 0x00001fcf)
[    5.237340] arm-smmu-v3 arm-smmu-v3.10.auto: allocated 65536 entries for cmdq
[    5.244527] arm-smmu-v3 arm-smmu-v3.10.auto: allocated 32768 entries for evtq
[    5.251527] arm-smmu-v3 arm-smmu-v3.10.auto: SMMU currently enabled! Resetting...
[    5.259138] arm-smmu-v3 arm-smmu-v3.15.auto: option mask 0x0
[    5.264651] arm-smmu-v3 arm-smmu-v3.15.auto: ias 44-bit, oas 44-bit (features 0x00001fcf)
[    5.272862] arm-smmu-v3 arm-smmu-v3.15.auto: allocated 65536 entries for cmdq
[    5.280143] arm-smmu-v3 arm-smmu-v3.15.auto: allocated 32768 entries for evtq
[    5.287030] arm-smmu-v3 arm-smmu-v3.15.auto: SMMU currently enabled! Resetting...
[    5.294644] arm-smmu-v3 arm-smmu-v3.20.auto: option mask 0x0
[    5.300162] arm-smmu-v3 arm-smmu-v3.20.auto: ias 44-bit, oas 44-bit (features 0x00001fcf)
[    5.308349] arm-smmu-v3 arm-smmu-v3.20.auto: allocated 65536 entries for cmdq
[    5.315534] arm-smmu-v3 arm-smmu-v3.20.auto: allocated 32768 entries for evtq
[    5.322531] arm-smmu-v3 arm-smmu-v3.20.auto: SMMU currently enabled! Resetting...
[    5.330145] arm-smmu-v3 arm-smmu-v3.25.auto: option mask 0x0
[    5.335656] arm-smmu-v3 arm-smmu-v3.25.auto: ias 44-bit, oas 44-bit (features 0x00001fcf)
[    5.343869] arm-smmu-v3 arm-smmu-v3.25.auto: allocated 65536 entries for cmdq
[    5.351152] arm-smmu-v3 arm-smmu-v3.25.auto: allocated 32768 entries for evtq
[    5.358035] arm-smmu-v3 arm-smmu-v3.25.auto: SMMU currently enabled! Resetting...

And no messages for arm-smmu-v3-pmcg

R/
Sam


On Thu, 5 Sep 2024 20:14:55 -0400 Brian Masney <bmasney@redhat.com> wrote:
> Hi Jeffrey,
> 
> On Thu, Aug 29, 2024 at 11:01 AM Jeffrey Hugo <quic_jhugo@quicinc.com> wrote:
> Interesting, I haven't seen this in my testing.  I'll go swing back and
> > try to figure out why.
> >
> > For future reference, I'm still supporting Amberwing/QDF2400.
> > Addressing emails to me is a good way to get my attention.
>
> I also see an unrelated error when booting the Qualcomm Amberwing with 6.11.0-rc5:
>
> [   14.159483] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.1.auto: error -EINVAL: invalid resource (null)
> [   14.167076] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.1.auto: probe with driver arm-smmu-v3-pmcg failed with error -22
> [   14.177707] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.2.auto: error -EINVAL: invalid resource (null)
> [   14.185557] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.2.auto: probe with driver arm-smmu-v3-pmcg failed with error -22
>...
>
> I spent 20 minutes troubleshooting this in the arm smmu driver,
> however I didn't see anything obvious. I attached the full dmesg.
> Ernesto: Are you seeing that on your Amberwing?
>
> Brian


^ permalink raw reply	[flat|nested] 13+ messages in thread
* qcom-rng is broken for acpi
@ 2024-08-28 18:40 Ernesto A. Fernández
  2024-08-28 19:03 ` Trilok Soni
  0 siblings, 1 reply; 13+ messages in thread
From: Ernesto A. Fernández @ 2024-08-28 18:40 UTC (permalink / raw)
  To: linux-crypto, Herbert Xu, David S. Miller, linux-arm-msm; +Cc: Om Prakash Singh

Hi, I have a bug to report.

I'm getting a null pointer dereference inside qcom_rng_probe() when this
driver gets loaded. The problem comes from here:

  rng->of_data = (struct qcom_rng_of_data *)of_device_get_match_data(&pdev->dev);

because of_device_get_match_data() will just return null for acpi. It seems
that acpi was left behind by the changes in commit f29cd5bb64c2 ("crypto:
qcom-rng - Add hw_random interface support").

Thanks in advance, let me know if you need anything else.
Ernesto

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-10-08 20:13 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-06 20:33 qcom-rng is broken for acpi Sam Bingner
  -- strict thread matches above, loose matches on Subject: below --
2024-08-28 18:40 Ernesto A. Fernández
2024-08-28 19:03 ` Trilok Soni
2024-08-28 20:13   ` Ernesto A. Fernández
2024-08-28 20:28     ` Ernesto A. Fernández
2024-08-29  1:25     ` Brian Masney
2024-08-29 14:55       ` Jeffrey Hugo
2024-09-06  0:14         ` Brian Masney
2024-09-16  5:07           ` Jeffrey Hugo
2024-09-16 17:42             ` Jeffrey Hugo
2024-09-16 19:40               ` Brian Masney
2024-09-17 21:24                 ` Jeffrey Hugo
2024-10-08 20:08                   ` Jeffrey Hugo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox