s390: Still CI failures in linux-next kernel

s390: Still CI failures in linux-next kernel

[Harald Freudenberger]

Hello Herbert
with the latest fix still the CI complains about the sha384 algorithm.
Looks like you forget to adapt the init for sha384, with the following
hunk all works fine:

diff --git a/arch/s390/crypto/sha512_s390.c 
b/arch/s390/crypto/sha512_s390.c
index 14818fcc9cd4..fa6a3a0dba57 100644
--- a/arch/s390/crypto/sha512_s390.c
+++ b/arch/s390/crypto/sha512_s390.c
@@ -86,15 +86,16 @@ static int sha384_init(struct shash_desc *desc)
  {
         struct s390_sha_ctx *ctx = shash_desc_ctx(desc);

-       *(__u64 *)&ctx->state[0] = SHA384_H0;
-       *(__u64 *)&ctx->state[2] = SHA384_H1;
-       *(__u64 *)&ctx->state[4] = SHA384_H2;
-       *(__u64 *)&ctx->state[6] = SHA384_H3;
-       *(__u64 *)&ctx->state[8] = SHA384_H4;
-       *(__u64 *)&ctx->state[10] = SHA384_H5;
-       *(__u64 *)&ctx->state[12] = SHA384_H6;
-       *(__u64 *)&ctx->state[14] = SHA384_H7;
+       ctx->sha512.state[0] = SHA384_H0;
+       ctx->sha512.state[1] = SHA384_H1;
+       ctx->sha512.state[2] = SHA384_H2;
+       ctx->sha512.state[3] = SHA384_H3;
+       ctx->sha512.state[4] = SHA384_H4;
+       ctx->sha512.state[5] = SHA384_H5;
+       ctx->sha512.state[6] = SHA384_H6;
+       ctx->sha512.state[7] = SHA384_H7;
         ctx->count = 0;
+       ctx->sha512.count_hi = 0;
         ctx->func = CPACF_KIMD_SHA_512;

         return 0;

Thanks and have a nice day
Harald Freudenberger

Re: s390: Still CI failures in linux-next kernel

[Herbert Xu]

On Mon, May 05, 2025 at 02:52:30PM +0200, Harald Freudenberger wrote:
> Hello Herbert
> with the latest fix still the CI complains about the sha384 algorithm.
> Looks like you forget to adapt the init for sha384, with the following
> hunk all works fine:

Thanks Harald.  Yes I just received a similar report from Ingo
and sent out a similar patch.

I'll push it out now.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt