From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Cc: "gregory.price@memverge.com" <gregory.price@memverge.com>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"dave@stgolabs.net" <dave@stgolabs.net>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: Re: [PATCH ndctl 2/7] cxl: add a type attribute to region listings
Date: Wed, 8 Feb 2023 06:10:17 +0000 [thread overview]
Message-ID: <1c439ff6bac64030a8472b9daf5721515ac6639a.camel@intel.com> (raw)
In-Reply-To: <63e3378cb5248_e3dae2943f@dwillia2-xfh.jf.intel.com.notmuch>
On Tue, 2023-02-07 at 21:47 -0800, Dan Williams wrote:
> Vishal Verma wrote:
<..>
> >
> > @@ -853,6 +854,10 @@ struct json_object *util_cxl_region_to_json(struct cxl_region *region,
> > json_object_object_add(jregion, "size", jobj);
> > }
> >
> > + jobj = json_object_new_string(cxl_decoder_mode_name(mode));
> > + if (jobj)
> > + json_object_object_add(jregion, "type", jobj);
> > +
>
> I am thinking this should be gated by an:
>
> if (mode != CXL_DECODER_MODE_NONE)
>
> ...just to avoid saying "type : none" on older kernels where there is an
> implied non-NONE type.
Yep makes sense, I'll add this.
>
> Otherwise looks good to me:
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2023-02-08 6:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 19:16 [PATCH ndctl 0/7] cxl: add support for listing and creating volatile regions Vishal Verma
2023-02-07 19:16 ` [PATCH ndctl 1/7] cxl/region: skip region_actions for region creation Vishal Verma
2023-02-07 22:07 ` Fan Ni
2023-02-08 0:19 ` Verma, Vishal L
2023-02-08 3:45 ` Ira Weiny
2023-02-08 5:41 ` Dan Williams
2023-02-07 19:16 ` [PATCH ndctl 2/7] cxl: add a type attribute to region listings Vishal Verma
2023-02-08 3:46 ` Ira Weiny
2023-02-08 5:47 ` Dan Williams
2023-02-08 6:10 ` Verma, Vishal L [this message]
2023-02-10 0:47 ` Fan Ni
2023-02-07 19:16 ` [PATCH ndctl 3/7] cxl: add core plumbing for creation of ram regions Vishal Verma
2023-02-08 3:55 ` Ira Weiny
2023-02-08 6:23 ` Verma, Vishal L
2023-02-08 22:07 ` Ira Weiny
2023-02-08 5:49 ` Dan Williams
2023-02-10 1:04 ` Fan Ni
2023-02-10 1:10 ` Verma, Vishal L
2023-02-10 1:15 ` Fan Ni
2023-02-07 19:16 ` [PATCH ndctl 4/7] cxl/region: accept user-supplied UUIDs for pmem regions Vishal Verma
2023-02-08 3:56 ` Ira Weiny
2023-02-08 5:51 ` Dan Williams
2023-02-07 19:16 ` [PATCH ndctl 5/7] cxl/region: determine region type based on root decoder capability Vishal Verma
2023-02-08 4:07 ` Ira Weiny
2023-02-08 6:34 ` Verma, Vishal L
2023-02-08 22:09 ` Ira Weiny
2023-02-08 5:55 ` Dan Williams
2023-02-08 6:36 ` Verma, Vishal L
2023-02-07 19:16 ` [PATCH ndctl 6/7] cxl/list: Include regions in the verbose listing Vishal Verma
2023-02-08 4:08 ` Ira Weiny
2023-02-07 19:16 ` [PATCH ndctl 7/7] cxl/list: Enumerate device-dax properties for regions Vishal Verma
2023-02-08 4:15 ` Ira Weiny
2023-02-08 6:00 ` Dan Williams
2023-02-08 6:48 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c439ff6bac64030a8472b9daf5721515ac6639a.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=gregory.price@memverge.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox