* [PATCH v2] tools/testing/cxl: Remove cxl_test module math loading message
@ 2023-01-25 18:13 alison.schofield
2023-01-25 18:47 ` Verma, Vishal L
2023-01-25 22:35 ` Dave Jiang
0 siblings, 2 replies; 4+ messages in thread
From: alison.schofield @ 2023-01-25 18:13 UTC (permalink / raw)
To: Dan Williams, Ira Weiny, Vishal Verma, Ben Widawsky, Dave Jiang
Cc: Alison Schofield, linux-cxl
From: Alison Schofield <alison.schofield@intel.com>
Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added
a module parameter to cxl_test for the interleave_arithmetic option.
In doing so, it also added this dev_dbg() message describing which
option cxl_test used during load:
"[ 111.743246] (NULL device *): cxl_test loading modulo math option"
That "(NULL device *)" has raised needless user concern and the info
emitted can be discovered elsewhere.
Remove the dev_dbg() messages and make the module_param readable via
sysfs in case a lookup is wanted.
Fixes: Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
Changes in v2:
- Use correct Fixes Tag in commit log. (Ira)
- Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
- Commit msg: s/modulo/module, s/messages/message
- No change in code
tools/testing/cxl/test/cxl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
index 30ee680d38ff..ede84de69f59 100644
--- a/tools/testing/cxl/test/cxl.c
+++ b/tools/testing/cxl/test/cxl.c
@@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
if (interleave_arithmetic == 1) {
cfmws_start = CFMWS_XOR_ARRAY_START;
cfmws_end = CFMWS_XOR_ARRAY_END;
- dev_dbg(NULL, "cxl_test loading xor math option\n");
} else {
cfmws_start = CFMWS_MOD_ARRAY_START;
cfmws_end = CFMWS_MOD_ARRAY_END;
- dev_dbg(NULL, "cxl_test loading modulo math option\n");
}
rc = populate_cedt();
@@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
unregister_cxl_mock_ops(&cxl_mock_ops);
}
-module_param(interleave_arithmetic, int, 0000);
+module_param(interleave_arithmetic, int, 0444);
MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
module_init(cxl_test_init);
module_exit(cxl_test_exit);
base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] tools/testing/cxl: Remove cxl_test module math loading message
2023-01-25 18:13 [PATCH v2] tools/testing/cxl: Remove cxl_test module math loading message alison.schofield
@ 2023-01-25 18:47 ` Verma, Vishal L
2023-01-25 22:35 ` Dave Jiang
1 sibling, 0 replies; 4+ messages in thread
From: Verma, Vishal L @ 2023-01-25 18:47 UTC (permalink / raw)
To: Williams, Dan J, Schofield, Alison, Jiang, Dave,
bwidawsk@kernel.org, Weiny, Ira
Cc: linux-cxl@vger.kernel.org
On Wed, 2023-01-25 at 10:13 -0800, alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added
> a module parameter to cxl_test for the interleave_arithmetic option.
> In doing so, it also added this dev_dbg() message describing which
> option cxl_test used during load:
> "[ 111.743246] (NULL device *): cxl_test loading modulo math option"
>
> That "(NULL device *)" has raised needless user concern and the info
> emitted can be discovered elsewhere.
>
> Remove the dev_dbg() messages and make the module_param readable via
> sysfs in case a lookup is wanted.
>
> Fixes: Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> ---
>
> Changes in v2:
> - Use correct Fixes Tag in commit log. (Ira)
> - Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
> - Commit msg: s/modulo/module, s/messages/message
> - No change in code
>
> tools/testing/cxl/test/cxl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Looks good,
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 30ee680d38ff..ede84de69f59 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
> if (interleave_arithmetic == 1) {
> cfmws_start = CFMWS_XOR_ARRAY_START;
> cfmws_end = CFMWS_XOR_ARRAY_END;
> - dev_dbg(NULL, "cxl_test loading xor math option\n");
> } else {
> cfmws_start = CFMWS_MOD_ARRAY_START;
> cfmws_end = CFMWS_MOD_ARRAY_END;
> - dev_dbg(NULL, "cxl_test loading modulo math option\n");
> }
>
> rc = populate_cedt();
> @@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
> unregister_cxl_mock_ops(&cxl_mock_ops);
> }
>
> -module_param(interleave_arithmetic, int, 0000);
> +module_param(interleave_arithmetic, int, 0444);
> MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
> module_init(cxl_test_init);
> module_exit(cxl_test_exit);
>
> base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] tools/testing/cxl: Remove cxl_test module math loading message
2023-01-25 18:13 [PATCH v2] tools/testing/cxl: Remove cxl_test module math loading message alison.schofield
2023-01-25 18:47 ` Verma, Vishal L
@ 2023-01-25 22:35 ` Dave Jiang
2023-01-26 1:18 ` Alison Schofield
1 sibling, 1 reply; 4+ messages in thread
From: Dave Jiang @ 2023-01-25 22:35 UTC (permalink / raw)
To: alison.schofield, Dan Williams, Ira Weiny, Vishal Verma,
Ben Widawsky
Cc: linux-cxl
On 1/25/23 11:13 AM, alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added
> a module parameter to cxl_test for the interleave_arithmetic option.
> In doing so, it also added this dev_dbg() message describing which
> option cxl_test used during load:
> "[ 111.743246] (NULL device *): cxl_test loading modulo math option"
>
> That "(NULL device *)" has raised needless user concern and the info
> emitted can be discovered elsewhere.
>
> Remove the dev_dbg() messages and make the module_param readable via
> sysfs in case a lookup is wanted.
Should the module_param perm change go to a second patch since it has
nothing to do with removal of the debug warning?
>
> Fixes: Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> ---
>
> Changes in v2:
> - Use correct Fixes Tag in commit log. (Ira)
> - Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
> - Commit msg: s/modulo/module, s/messages/message
> - No change in code
>
> tools/testing/cxl/test/cxl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 30ee680d38ff..ede84de69f59 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
> if (interleave_arithmetic == 1) {
> cfmws_start = CFMWS_XOR_ARRAY_START;
> cfmws_end = CFMWS_XOR_ARRAY_END;
> - dev_dbg(NULL, "cxl_test loading xor math option\n");
> } else {
> cfmws_start = CFMWS_MOD_ARRAY_START;
> cfmws_end = CFMWS_MOD_ARRAY_END;
> - dev_dbg(NULL, "cxl_test loading modulo math option\n");
> }
>
> rc = populate_cedt();
> @@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
> unregister_cxl_mock_ops(&cxl_mock_ops);
> }
>
> -module_param(interleave_arithmetic, int, 0000);
> +module_param(interleave_arithmetic, int, 0444);
> MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
> module_init(cxl_test_init);
> module_exit(cxl_test_exit);
>
> base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] tools/testing/cxl: Remove cxl_test module math loading message
2023-01-25 22:35 ` Dave Jiang
@ 2023-01-26 1:18 ` Alison Schofield
0 siblings, 0 replies; 4+ messages in thread
From: Alison Schofield @ 2023-01-26 1:18 UTC (permalink / raw)
To: Dave Jiang; +Cc: Dan Williams, Ira Weiny, Vishal Verma, Ben Widawsky, linux-cxl
On Wed, Jan 25, 2023 at 03:35:32PM -0700, Dave Jiang wrote:
>
>
> On 1/25/23 11:13 AM, alison.schofield@intel.com wrote:
> > From: Alison Schofield <alison.schofield@intel.com>
> >
> > Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added
> > a module parameter to cxl_test for the interleave_arithmetic option.
> > In doing so, it also added this dev_dbg() message describing which
> > option cxl_test used during load:
> > "[ 111.743246] (NULL device *): cxl_test loading modulo math option"
> >
> > That "(NULL device *)" has raised needless user concern and the info
> > emitted can be discovered elsewhere.
> >
> > Remove the dev_dbg() messages and make the module_param readable via
> > sysfs in case a lookup is wanted.
>
> Should the module_param perm change go to a second patch since it has
> nothing to do with removal of the debug warning?
>
Thanks Dave -
I don't think a second patch, but I can make the connection better
between the 2 pieces. Where it says the 'info emitted can be discovered
elsewhere', elsewhere is that now readable param.
I'll rev it. Also, I might need to base on a fixes branch, rather than
cxl/next, like I've been doing.
Will check.
> >
> > Fixes: Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")
> > Suggested-by: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> > ---
> >
> > Changes in v2:
> > - Use correct Fixes Tag in commit log. (Ira)
> > - Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
> > - Commit msg: s/modulo/module, s/messages/message
> > - No change in code
> >
> > tools/testing/cxl/test/cxl.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> > index 30ee680d38ff..ede84de69f59 100644
> > --- a/tools/testing/cxl/test/cxl.c
> > +++ b/tools/testing/cxl/test/cxl.c
> > @@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
> > if (interleave_arithmetic == 1) {
> > cfmws_start = CFMWS_XOR_ARRAY_START;
> > cfmws_end = CFMWS_XOR_ARRAY_END;
> > - dev_dbg(NULL, "cxl_test loading xor math option\n");
> > } else {
> > cfmws_start = CFMWS_MOD_ARRAY_START;
> > cfmws_end = CFMWS_MOD_ARRAY_END;
> > - dev_dbg(NULL, "cxl_test loading modulo math option\n");
> > }
> > rc = populate_cedt();
> > @@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
> > unregister_cxl_mock_ops(&cxl_mock_ops);
> > }
> > -module_param(interleave_arithmetic, int, 0000);
> > +module_param(interleave_arithmetic, int, 0444);
> > MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
> > module_init(cxl_test_init);
> > module_exit(cxl_test_exit);
> >
> > base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-26 1:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-25 18:13 [PATCH v2] tools/testing/cxl: Remove cxl_test module math loading message alison.schofield
2023-01-25 18:47 ` Verma, Vishal L
2023-01-25 22:35 ` Dave Jiang
2023-01-26 1:18 ` Alison Schofield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).