Linux CXL
 help / color / mirror / Atom feed
From: Raghu H <raghuhack78@gmail.com>
To: linux-cxl@vger.kernel.org,
	Alison Schofield <alison.schofield@intel.com>,
	raghuhack78@gmail.com
Subject: [STYLE v1 0/3] Fixing check patch styling issues
Date: Wed, 19 Apr 2023 11:14:40 +0000	[thread overview]
Message-ID: <20230419111443.231151-1-raghuhack78@gmail.com> (raw)

The following patches are cleanup or fixing the styling issues found
using checkpatch

In cxl/core/mbox.c, in case of null check failure, returning errno or
-ENOMEM in this case is good enough, removing the redundant dev_err
message.

In cxl/core/port.c, there is line of spaces in the definition which
violates checkpatch coding sytle, restructured the definition to use
tabs

In cxl/core/region.c, the else is not required after the return
statement, cleaned it up.

Verified the build and sanity by booting the guest VM using the freshly
built components.

Raghu H (3):
  cxl/mbox: remove redundant debug msg
  cxl/core/port: Use tabs to fix styling errors
  cxl/core/region:Remove else after return statement

 drivers/cxl/core/mbox.c   |  4 +---
 drivers/cxl/core/port.c   | 18 +++++++++---------
 drivers/cxl/core/region.c |  7 +++----
 3 files changed, 13 insertions(+), 16 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-04-19 11:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 11:14 Raghu H [this message]
2023-04-19 11:14 ` [STYLE v1 1/3] cxl/mbox: remove redundant debug msg Raghu H
2023-04-27 19:05   ` Ira Weiny
2023-04-27 19:32   ` Alison Schofield
2023-04-19 11:14 ` [STYLE v1 2/3] cxl/core/port: Use tabs to fix styling errors Raghu H
2023-04-27 19:06   ` Ira Weiny
2023-04-19 11:14 ` [STYLE v1 3/3] cxl/core/region:Remove else after return statement Raghu H
2023-04-27 19:13   ` Ira Weiny
2023-04-27 19:49     ` Alison Schofield
2023-04-28  0:00       ` RAGHU H
2023-04-27 19:46 ` [STYLE v1 0/3] Fixing check patch styling issues Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230419111443.231151-1-raghuhack78@gmail.com \
    --to=raghuhack78@gmail.com \
    --cc=alison.schofield@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox