From: Raghu H <raghuhack78@gmail.com>
To: linux-cxl@vger.kernel.org,
Alison Schofield <alison.schofield@intel.com>,
raghuhack78@gmail.com, Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: [STYLE v1 3/3] cxl/core/region:Remove else after return statement
Date: Wed, 19 Apr 2023 11:14:43 +0000 [thread overview]
Message-ID: <20230419111443.231151-4-raghuhack78@gmail.com> (raw)
In-Reply-To: <20230419111443.231151-1-raghuhack78@gmail.com>
The else section here is redundant after return statement, removing it.
Sanity and correctness is not affected due to this fix.
Signed-off-by: Raghu H <raghuhack78@gmail.com>
---
drivers/cxl/core/region.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index f29028148806..1d695107b4a7 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -2666,11 +2666,10 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
return 0;
- } else {
- dev_err(&cxlr->dev,
- "Failed to synchronize CPU cache state\n");
- return -ENXIO;
}
+ dev_err(&cxlr->dev,
+ "Failed to synchronize CPU cache state\n");
+ return -ENXIO;
}
cpu_cache_invalidate_memregion(IORES_DESC_CXL);
--
2.39.2
next prev parent reply other threads:[~2023-04-19 11:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 11:14 [STYLE v1 0/3] Fixing check patch styling issues Raghu H
2023-04-19 11:14 ` [STYLE v1 1/3] cxl/mbox: remove redundant debug msg Raghu H
2023-04-27 19:05 ` Ira Weiny
2023-04-27 19:32 ` Alison Schofield
2023-04-19 11:14 ` [STYLE v1 2/3] cxl/core/port: Use tabs to fix styling errors Raghu H
2023-04-27 19:06 ` Ira Weiny
2023-04-19 11:14 ` Raghu H [this message]
2023-04-27 19:13 ` [STYLE v1 3/3] cxl/core/region:Remove else after return statement Ira Weiny
2023-04-27 19:49 ` Alison Schofield
2023-04-28 0:00 ` RAGHU H
2023-04-27 19:46 ` [STYLE v1 0/3] Fixing check patch styling issues Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419111443.231151-4-raghuhack78@gmail.com \
--to=raghuhack78@gmail.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox