From: Ira Weiny <ira.weiny@intel.com>
To: Raghu H <raghuhack78@gmail.com>, <linux-cxl@vger.kernel.org>,
"Alison Schofield" <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [STYLE v1 1/3] cxl/mbox: remove redundant debug msg
Date: Thu, 27 Apr 2023 12:05:24 -0700 [thread overview]
Message-ID: <644ac773f2929_182a92942f@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20230419111443.231151-2-raghuhack78@gmail.com>
Raghu H wrote:
> A return of errno should be good enough if the memory allocation fails,
> the debug message here is redundatant as per the coding style, removing it.
>
> Signed-off-by: Raghu H <raghuhack78@gmail.com>
I'm not seeing a lot of value in this error message either. There are
plenty of other places probe can fail without any errors at all.
I guess:
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
next prev parent reply other threads:[~2023-04-27 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 11:14 [STYLE v1 0/3] Fixing check patch styling issues Raghu H
2023-04-19 11:14 ` [STYLE v1 1/3] cxl/mbox: remove redundant debug msg Raghu H
2023-04-27 19:05 ` Ira Weiny [this message]
2023-04-27 19:32 ` Alison Schofield
2023-04-19 11:14 ` [STYLE v1 2/3] cxl/core/port: Use tabs to fix styling errors Raghu H
2023-04-27 19:06 ` Ira Weiny
2023-04-19 11:14 ` [STYLE v1 3/3] cxl/core/region:Remove else after return statement Raghu H
2023-04-27 19:13 ` Ira Weiny
2023-04-27 19:49 ` Alison Schofield
2023-04-28 0:00 ` RAGHU H
2023-04-27 19:46 ` [STYLE v1 0/3] Fixing check patch styling issues Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644ac773f2929_182a92942f@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raghuhack78@gmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox