Linux CXL
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: dan.j.williams@intel.com
Cc: Jonathan.Cameron@huawei.com, dave.jiang@intel.com,
	alison.schofield@intel.com, ira.weiny@intel.com,
	vishal.l.verma@intel.com, fan.ni@samsung.com,
	a.manzanares@samsung.com, dave@stgolabs.net,
	linux-cxl@vger.kernel.org
Subject: [PATCH 1/7] cxl/pci: Allocate irq vectors earlier in pci probe
Date: Fri, 21 Apr 2023 02:23:15 -0700	[thread overview]
Message-ID: <20230421092321.12741-2-dave@stgolabs.net> (raw)
In-Reply-To: <20230421092321.12741-1-dave@stgolabs.net>

Move the cxl_alloc_irq_vectors() call further up in the probing
in order to allow for mailbox interrupt usage. No change in
semantics.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
 drivers/cxl/pci.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
index 60b23624d167..39b829a29f6c 100644
--- a/drivers/cxl/pci.c
+++ b/drivers/cxl/pci.c
@@ -757,6 +757,10 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	if (rc)
 		dev_dbg(&pdev->dev, "Failed to map RAS capability.\n");
 
+	rc = cxl_alloc_irq_vectors(pdev);
+	if (rc)
+		return rc;
+
 	rc = cxl_pci_setup_mailbox(cxlds);
 	if (rc)
 		return rc;
@@ -777,10 +781,6 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	if (rc)
 		return rc;
 
-	rc = cxl_alloc_irq_vectors(pdev);
-	if (rc)
-		return rc;
-
 	cxlmd = devm_cxl_add_memdev(cxlds);
 	if (IS_ERR(cxlmd))
 		return PTR_ERR(cxlmd);
-- 
2.40.0


  reply	other threads:[~2023-04-21  9:55 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21  9:23 [PATCH v4 0/7] cxl: Background cmds and device sanitation Davidlohr Bueso
2023-04-21  9:23 ` Davidlohr Bueso [this message]
2023-04-28 16:09   ` [PATCH 1/7] cxl/pci: Allocate irq vectors earlier in pci probe Dave Jiang
2023-05-11 13:55   ` Jonathan Cameron
2023-04-21  9:23 ` [PATCH 2/7] cxl/mbox: Add background cmd handling machinery Davidlohr Bueso
2023-04-23  7:54   ` Li, Ming
2023-04-23 20:51     ` Davidlohr Bueso
2023-04-28 16:21   ` Dave Jiang
2023-04-28 17:18     ` Davidlohr Bueso
2023-04-28 21:04       ` Dave Jiang
2023-04-28 22:03         ` Davidlohr Bueso
2023-05-01 15:56           ` Davidlohr Bueso
2023-05-11 14:23   ` Jonathan Cameron
2023-05-11 16:04     ` Davidlohr Bueso
2023-05-12 17:05       ` Jonathan Cameron
2023-04-21  9:23 ` [PATCH 3/7] cxl/mbox: Add sanitation " Davidlohr Bueso
2023-04-28 16:43   ` Dave Jiang
2023-04-28 16:46     ` Davidlohr Bueso
2023-04-28 17:37       ` Dave Jiang
2023-05-11 14:45   ` Jonathan Cameron
2023-05-11 16:48     ` Davidlohr Bueso
2023-05-12 17:02       ` Jonathan Cameron
2023-04-21  9:23 ` [PATCH 4/7] cxl/mem: Wire up Sanitation support Davidlohr Bueso
2023-04-21 20:04   ` kernel test robot
2023-04-21 20:24   ` kernel test robot
2023-05-11 15:07   ` Jonathan Cameron
2023-05-11 17:23     ` Davidlohr Bueso
2023-05-12 17:00       ` Jonathan Cameron
2023-04-21  9:23 ` [PATCH 5/7] cxl/test: Add Sanitize opcode support Davidlohr Bueso
2023-05-11 15:09   ` Jonathan Cameron
2023-05-11 15:13     ` Davidlohr Bueso
2023-04-21  9:23 ` [PATCH 6/7] cxl/mem: Support Secure Erase Davidlohr Bueso
2023-05-11 15:10   ` Jonathan Cameron
2023-04-21  9:23 ` [PATCH 7/7] cxl/test: Add Secure Erase opcode support Davidlohr Bueso
2023-05-11 15:10   ` Jonathan Cameron
2023-04-23  2:05 ` [PATCH v4 0/7] cxl: Background cmds and device sanitation Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230421092321.12741-2-dave@stgolabs.net \
    --to=dave@stgolabs.net \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=a.manzanares@samsung.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=fan.ni@samsung.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox