Linux CXL
 help / color / mirror / Atom feed
From: "Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>
To: kobayashi.da-06@jp.fujitsu.com, linux-cxl@vger.kernel.org
Cc: y-goto@fujitsu.com, linux-pci@vger.kernel.org, mj@ucw.cz,
	dan.j.williams@intel.com,
	"Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>
Subject: [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1 devices
Date: Tue, 12 Mar 2024 17:05:58 +0900	[thread overview]
Message-ID: <20240312080559.14904-3-kobayashi.da-06@fujitsu.com> (raw)
In-Reply-To: <20240312080559.14904-1-kobayashi.da-06@fujitsu.com>

This patch removes conditional branching that does not comply with the specifications.

In the existing code, there is a conditional branch that compares "chbs->length" 
with "CXL_RCRB_SIZE". However, according to the specifications, "chbs->length" 
indicates the length of the CHBS structure in the cedt, not the size of the 
configuration space. Therefore, since this condition does not comply with
the specifications(cxl3.0 specification 9.17.1), remove it.

Signed-off-by: "Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>
---
 drivers/cxl/acpi.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
index dcf2b39e1048..cf15c5130428 100644
--- a/drivers/cxl/acpi.c
+++ b/drivers/cxl/acpi.c
@@ -477,10 +477,6 @@ static int cxl_get_chbs_iter(union acpi_subtable_headers *header, void *arg,
 	if (!chbs->base)
 		return 0;
 
-	if (chbs->cxl_version == ACPI_CEDT_CHBS_VERSION_CXL11 &&
-	    chbs->length != CXL_RCRB_SIZE)
-		return 0;
-
 	ctx->base = chbs->base;
 
 	return 0;
-- 
2.43.0


  parent reply	other threads:[~2024-03-12  8:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  8:05 [PATCH v3 0/3] Display cxl1.1 device link status Kobayashi,Daisuke
2024-03-12  8:05 ` [PATCH v3 1/3] Add sysfs attribute for CXL 1.1 " Kobayashi,Daisuke
2024-03-26 19:51   ` Dan Williams
2024-03-28  1:47     ` Daisuke Kobayashi (Fujitsu)
2024-04-03  9:40       ` Daisuke Kobayashi (Fujitsu)
2024-04-05  8:31         ` Daisuke Kobayashi (Fujitsu)
2024-04-08 21:43           ` Dan Williams
2024-04-09  4:55             ` Daisuke Kobayashi (Fujitsu)
2024-04-05 17:25         ` Jonathan Cameron
2024-04-08 21:32         ` Dan Williams
2024-04-09 14:59   ` Bjorn Helgaas
2024-04-09 15:00     ` Bjorn Helgaas
2024-03-12  8:05 ` Kobayashi,Daisuke [this message]
2024-03-26 20:00   ` [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1 devices Dan Williams
2024-03-27  8:26     ` Daisuke Kobayashi (Fujitsu)
2024-03-12  8:05 ` [PATCH v3 3/3] Add function to display cxl1.1 device link status Kobayashi,Daisuke
2024-03-26 20:05   ` Dan Williams
2024-03-27  8:27     ` Daisuke Kobayashi (Fujitsu)
2024-03-29 22:23   ` Martin Mareš
2024-03-30  1:15     ` Dan Williams
2024-03-31  1:03       ` Martin Mareš
2024-04-01 17:47         ` Dan Williams
2024-04-02  7:09           ` Daisuke Kobayashi (Fujitsu)
2024-03-25  4:49 ` [PATCH v3 0/3] Display " Daisuke Kobayashi (Fujitsu)
2024-03-26 19:15 ` Dan Williams
2024-03-27  8:24   ` Daisuke Kobayashi (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240312080559.14904-3-kobayashi.da-06@fujitsu.com \
    --to=kobayashi.da-06@fujitsu.com \
    --cc=dan.j.williams@intel.com \
    --cc=kobayashi.da-06@jp.fujitsu.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mj@ucw.cz \
    --cc=y-goto@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox