Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: "Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>,
	<kobayashi.da-06@jp.fujitsu.com>, <linux-cxl@vger.kernel.org>
Cc: <y-goto@fujitsu.com>, <linux-pci@vger.kernel.org>, <mj@ucw.cz>,
	<dan.j.williams@intel.com>,
	KobayashiDaisuke <kobayashi.da-06@fujitsu.com>
Subject: Re: [PATCH v3 3/3] Add function to display cxl1.1 device link status
Date: Tue, 26 Mar 2024 13:05:04 -0700	[thread overview]
Message-ID: <66032a6fe9e01_4a98a294d7@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20240312080559.14904-4-kobayashi.da-06@fujitsu.com>

Kobayashi,Daisuke wrote:
> From: KobayashiDaisuke <kobayashi.da-06@fujitsu.com>
> 
> This patch adds a function to output the link status of the CXL1.1 device
> when it is connected.
> 
> In CXL1.1, the link status of the device is included in the RCRB mapped to
> the memory mapped register area. The value of that register is outputted
> to sysfs, and based on that, displays the link status information.
> 
> Signed-off-by: "KobayashiDaisuke" <kobayashi.da-06@fujitsu.com>
> ---
>  lib/access.c | 29 +++++++++++++++++++++
>  lib/pci.h    |  2 ++
>  ls-caps.c    | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 104 insertions(+)

Including a userspace patch in a kernel patch submission breaks kernel
patch management tools like b4 shazam:

---
$ b4 shazam 20240312080559.14904-1-kobayashi.da-06@fujitsu.com
Grabbing thread from lore.kernel.org/all/20240312080559.14904-1-kobayashi.da-06@fujitsu.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 8 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v3 1/3] Add sysfs attribute for CXL 1.1 device link status
  ✓ [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1 devices
  ✓ [PATCH v3 3/3] Add function to display cxl1.1 device link status
  ---
  ✓ Signed: DKIM/fujitsu.com
---
Total patches: 3
---
Applying: Add sysfs attribute for CXL 1.1 device link status
Applying: Remove conditional branch that is not suitable for cxl1.1 devices
Applying: Add function to display cxl1.1 device link status
Patch failed at 0003 Add function to display cxl1.1 device link status
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
/home/dwillia2/git/linux/.git/rebase-apply/patch:117: trailing whitespace.
    w = (u16)strtoul(buf, NULL, 16);    
/home/dwillia2/git/linux/.git/rebase-apply/patch:130: trailing whitespace.
    w = (u16)strtoul(buf, NULL, 16);    
/home/dwillia2/git/linux/.git/rebase-apply/patch:158: trailing whitespace.
   
error: lib/access.c: does not exist in index
error: lib/pci.h: does not exist in index
error: ls-caps.c: does not exist in index
hint: Use 'git am --show-current-patch=diff' to see the failed patch
---

...and this patch should wait until the kernel change is accepted before
being submitted directly to the PCI utils project which does not watch
this linux-cxl mailing list.

  reply	other threads:[~2024-03-26 20:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  8:05 [PATCH v3 0/3] Display cxl1.1 device link status Kobayashi,Daisuke
2024-03-12  8:05 ` [PATCH v3 1/3] Add sysfs attribute for CXL 1.1 " Kobayashi,Daisuke
2024-03-26 19:51   ` Dan Williams
2024-03-28  1:47     ` Daisuke Kobayashi (Fujitsu)
2024-04-03  9:40       ` Daisuke Kobayashi (Fujitsu)
2024-04-05  8:31         ` Daisuke Kobayashi (Fujitsu)
2024-04-08 21:43           ` Dan Williams
2024-04-09  4:55             ` Daisuke Kobayashi (Fujitsu)
2024-04-05 17:25         ` Jonathan Cameron
2024-04-08 21:32         ` Dan Williams
2024-04-09 14:59   ` Bjorn Helgaas
2024-04-09 15:00     ` Bjorn Helgaas
2024-03-12  8:05 ` [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1 devices Kobayashi,Daisuke
2024-03-26 20:00   ` Dan Williams
2024-03-27  8:26     ` Daisuke Kobayashi (Fujitsu)
2024-03-12  8:05 ` [PATCH v3 3/3] Add function to display cxl1.1 device link status Kobayashi,Daisuke
2024-03-26 20:05   ` Dan Williams [this message]
2024-03-27  8:27     ` Daisuke Kobayashi (Fujitsu)
2024-03-29 22:23   ` Martin Mareš
2024-03-30  1:15     ` Dan Williams
2024-03-31  1:03       ` Martin Mareš
2024-04-01 17:47         ` Dan Williams
2024-04-02  7:09           ` Daisuke Kobayashi (Fujitsu)
2024-03-25  4:49 ` [PATCH v3 0/3] Display " Daisuke Kobayashi (Fujitsu)
2024-03-26 19:15 ` Dan Williams
2024-03-27  8:24   ` Daisuke Kobayashi (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66032a6fe9e01_4a98a294d7@dwillia2-mobl3.amr.corp.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=kobayashi.da-06@fujitsu.com \
    --cc=kobayashi.da-06@jp.fujitsu.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mj@ucw.cz \
    --cc=y-goto@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox