From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <alejandro.lucero-palau@amd.com>,
<dan.j.williams@intel.com>, <ira.weiny@intel.com>,
<vishal.l.verma@intel.com>, <alison.schofield@intel.com>,
<dave@stgolabs.net>, <fan.ni@samsung.com>,
Alejandro Lucero <alucerop@amd.com>
Subject: Re: [PATCH v2 1/2] cxl: Move mailbox related bits to the same context
Date: Wed, 28 Aug 2024 12:54:13 +0100 [thread overview]
Message-ID: <20240828125413.000045ab@Huawei.com> (raw)
In-Reply-To: <20240827215116.536126-2-dave.jiang@intel.com>
On Tue, 27 Aug 2024 14:49:49 -0700
Dave Jiang <dave.jiang@intel.com> wrote:
> Create a new 'struct cxl_mailbox' and move all mailbox related bits to
> it. This allows isolation of all CXL mailbox data in order to export
> some of the calls to external callers and avoid exporting of CXL driver
> specific bits such has device states. The allocation of
> 'struct cxl_mailbox' is also split out with cxl_mailbox_create() so the
> mailbox can be created independently.
>
> Reviewed-by: Fan Ni <fan.ni@samsung.com>
> Reviewed-by: Alejandro Lucero <alucerop@amd.com>
> Link: https://patch.msgid.link/20240724185649.2574627-2-dave.jiang@intel.com
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
If this is useful to Alejandro, it seems like the sort of
refactoring that makes sense anyway, so perhaps queue this
up this cycle if no negative feedback comes in?
Jonathan
next prev parent reply other threads:[~2024-08-28 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 21:49 [PATCH 0/2 v2] cxl: Pull out mailbox bits to be independent of cxl_dev_state Dave Jiang
2024-08-27 21:49 ` [PATCH v2 1/2] cxl: Move mailbox related bits to the same context Dave Jiang
2024-08-28 11:54 ` Jonathan Cameron [this message]
2024-08-29 15:41 ` Alison Schofield
2024-08-29 15:51 ` Dave Jiang
2024-08-29 16:50 ` Alison Schofield
2024-08-27 21:49 ` [PATCH v2 2/2] cxl: Convert cxl_internal_send_cmd() to use 'struct cxl_mailbox' as input Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828125413.000045ab@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alejandro.lucero-palau@amd.com \
--cc=alison.schofield@intel.com \
--cc=alucerop@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox