Re: [PATCH v2 1/2] cxl: Move mailbox related bits to the same context

[Dave Jiang <dave.jiang@intel.com>]

On 8/29/24 8:41 AM, Alison Schofield wrote:
> On Tue, Aug 27, 2024 at 02:49:49PM -0700, Dave Jiang wrote:
>> Create a new 'struct cxl_mailbox' and move all mailbox related bits to
>> it. This allows isolation of all CXL mailbox data in order to export
>> some of the calls to external callers and avoid exporting of CXL driver
>> specific bits such has device states. The allocation of
>> 'struct cxl_mailbox' is also split out with cxl_mailbox_create() so the
>> mailbox can be created independently.
> 
> The reasoning for this mentions 'external callers' yet this new struct
> is added to a header file that is still internal to the kernel. It's
> now available outside the CXL driver but not externally.
> 
> Does it belong in to include/uapi/linux/  and need to be documented
> in the driver-api/cxl/ (same as cxl_mem.h)
> 
external as to CXL but still kernel caller. this is not for user space consumption. for example future fwctl cxl support or maybe type2 support Alejandro is working on. 

> If it stays internal to include/linux/ note that cxl-event.h 
> already exists there w no 'cxl' subdir'. Maybe skip the subdir
> addition, or mv cxl-event.h along with.

yeah I need to move cxl-event.h into that dir as well. missed that. 

> 
> --Alison
> 
> snip
> 
>