Re: [PATCH v2 1/2] cxl: Move mailbox related bits to the same context

[Alison Schofield <alison.schofield@intel.com>]

On Tue, Aug 27, 2024 at 02:49:49PM -0700, Dave Jiang wrote:
> Create a new 'struct cxl_mailbox' and move all mailbox related bits to
> it. This allows isolation of all CXL mailbox data in order to export
> some of the calls to external callers and avoid exporting of CXL driver
> specific bits such has device states. The allocation of
> 'struct cxl_mailbox' is also split out with cxl_mailbox_create() so the
> mailbox can be created independently.

The reasoning for this mentions 'external callers' yet this new struct
is added to a header file that is still internal to the kernel. It's
now available outside the CXL driver but not externally.

Does it belong in to include/uapi/linux/  and need to be documented
in the driver-api/cxl/ (same as cxl_mem.h)

If it stays internal to include/linux/ note that cxl-event.h 
already exists there w no 'cxl' subdir'. Maybe skip the subdir
addition, or mv cxl-event.h along with.

--Alison

snip