From: Robert Richter <rrichter@amd.com>
To: Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>
Cc: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Gregory Price <gourry@gourry.net>,
"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
Terry Bowman <terry.bowman@amd.com>,
Robert Richter <rrichter@amd.com>
Subject: [PATCH v3 00/18] cxl: Address translation support, part 1: Cleanups and refactoring
Date: Tue, 11 Feb 2025 10:53:30 +0100 [thread overview]
Message-ID: <20250211095349.981096-1-rrichter@amd.com> (raw)
This series is the first part of adding support for CXL address
translation. It contains cleanup and code refactoring in preparation
of the actual implementation that will be sent in part 2. Cleanup and
code refactoring have been split in a separate series to reduce the
number of patches of the series. Even without address translation on
top this rework improves esp. the region code, cleans it up,
simplifies it and adds debugging messages to better analyze region
creation failures:
Content of patches:
* Patches 1: Remove else after return.
* Patches 2-4: Cleanups and comments around cxl_hdm_decode_init().
* Patches 5, 6, 13: Adding and modifying helper functions.
* Patches 7-12, 14: Refactoring of endpoint decoder setup.
* Patches 15-18: Adding and modifying debug messages.
Most of the patches were part of my first submission of v1 [1], some
of them were already reviewed.
[1] https://lore.kernel.org/linux-cxl/20250107141015.3367194-1-rrichter@amd.com/
v3:
* added tags to SOB chain,
* fixed NULL pointer dereference in cxl_find_root_decoder() (Alison),
* updated subject line of patches that add kernel messages and
included example log messages (Alison),
V2:
* rebased onto cxl/next,
* added tags to SOB chain,
* move patches with cleanups and refactoring into this separate
series (Dave),
* added patch "cxl/acpi: Unify CFMWS memory log messages with SRAT
messages" to improve CFMWS log messages,
* renamed endpoint decoder functions to cxl_endpoint_decoder_*() (Li),
* reworded patch description that moves find_cxl_root() and reworks
cxl_find_root_decoder() (Terry),
* small changes to cxl_find_root_decoder()/
cxl_endpoint_decoder_initialize() (Jonanthan),
* updated comment in cxl_port_find_switch_decoder() (Ben),
* cxl_endpoint_decoder_initialize(): Simplify variable declaration
(Jonathan, Ben),
* cxl_find_decoder_early(): Added comment on function usage (Gregory),
* reordered patches and reworded some of the subject for a better
structure.
Robert Richter (18):
cxl: Remove else after return
cxl/pci: Moving code in cxl_hdm_decode_init()
cxl/pci: cxl_hdm_decode_init: Move comment
cxl/pci: Add comments to cxl_hdm_decode_init()
cxl: Introduce parent_port_of() helper
cxl/region: Rename function to cxl_find_decoder_early()
cxl/region: Avoid duplicate call of cxl_find_decoder_early()
cxl/region: Move find_cxl_root() to cxl_add_to_region()
cxl/region: Factor out code to find the root decoder
cxl/region: Factor out code to find a root decoder's region
cxl/region: Split region registration into an initialization and
adding part
cxl/region: Use iterator to find the root port in
cxl_find_root_decoder()
cxl/region: Add function to find a port's switch decoder by range
cxl/region: Unfold cxl_find_root_decoder() into
cxl_endpoint_decoder_initialize()
cxl/region: Add a dev_warn() on registration failure
cxl/region: Add a dev_err() on missing target list entries
cxl: Add a dev_dbg() when a decoder was added to a port
cxl/acpi: Unify CFMWS memory log messages with SRAT messages
drivers/cxl/acpi.c | 12 ++-
drivers/cxl/core/cdat.c | 2 +-
drivers/cxl/core/hdm.c | 3 +-
drivers/cxl/core/pci.c | 44 +++++----
drivers/cxl/core/port.c | 15 +--
drivers/cxl/core/region.c | 190 +++++++++++++++++++++++++-------------
drivers/cxl/cxl.h | 9 +-
drivers/cxl/port.c | 22 ++---
8 files changed, 187 insertions(+), 110 deletions(-)
base-commit: 5585e342e8d38cc598279bdb87f235f8b954dd5a
--
2.39.5
next reply other threads:[~2025-02-11 9:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 9:53 Robert Richter [this message]
2025-02-11 9:53 ` [PATCH v3 01/18] cxl: Remove else after return Robert Richter
2025-02-11 9:53 ` [PATCH v3 02/18] cxl/pci: Moving code in cxl_hdm_decode_init() Robert Richter
2025-02-12 17:57 ` Jonathan Cameron
2025-02-20 1:03 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 03/18] cxl/pci: cxl_hdm_decode_init: Move comment Robert Richter
2025-02-12 18:09 ` Jonathan Cameron
2025-02-13 0:35 ` Robert Richter
2025-02-14 15:49 ` Jonathan Cameron
2025-03-06 9:38 ` Robert Richter
2025-02-11 9:53 ` [PATCH v3 04/18] cxl/pci: Add comments to cxl_hdm_decode_init() Robert Richter
2025-02-14 15:51 ` Jonathan Cameron
2025-02-11 9:53 ` [PATCH v3 05/18] cxl: Introduce parent_port_of() helper Robert Richter
2025-02-20 16:12 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 06/18] cxl/region: Rename function to cxl_find_decoder_early() Robert Richter
2025-02-14 15:58 ` Jonathan Cameron
2025-03-05 12:48 ` Robert Richter
2025-02-11 9:53 ` [PATCH v3 07/18] cxl/region: Avoid duplicate call of cxl_find_decoder_early() Robert Richter
2025-02-14 16:07 ` Jonathan Cameron
2025-03-06 9:16 ` Robert Richter
2025-02-11 9:53 ` [PATCH v3 08/18] cxl/region: Move find_cxl_root() to cxl_add_to_region() Robert Richter
2025-02-20 16:39 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 09/18] cxl/region: Factor out code to find the root decoder Robert Richter
2025-02-20 16:48 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 10/18] cxl/region: Factor out code to find a root decoder's region Robert Richter
2025-02-14 16:15 ` Jonathan Cameron
2025-02-20 16:50 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 11/18] cxl/region: Split region registration into an initialization and adding part Robert Richter
2025-02-14 16:24 ` Jonathan Cameron
2025-02-11 9:53 ` [PATCH v3 12/18] cxl/region: Use iterator to find the root port in cxl_find_root_decoder() Robert Richter
2025-02-20 17:17 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 13/18] cxl/region: Add function to find a port's switch decoder by range Robert Richter
2025-02-14 16:29 ` Jonathan Cameron
2025-02-20 17:23 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 14/18] cxl/region: Unfold cxl_find_root_decoder() into cxl_endpoint_decoder_initialize() Robert Richter
2025-02-14 16:33 ` Jonathan Cameron
2025-03-06 16:18 ` Robert Richter
2025-02-11 9:53 ` [PATCH v3 15/18] cxl/region: Add a dev_warn() on registration failure Robert Richter
2025-02-14 16:35 ` Jonathan Cameron
2025-02-20 17:35 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 16/18] cxl/region: Add a dev_err() on missing target list entries Robert Richter
2025-02-14 16:36 ` Jonathan Cameron
2025-02-20 17:44 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 17/18] cxl: Add a dev_dbg() when a decoder was added to a port Robert Richter
2025-02-14 16:37 ` Jonathan Cameron
2025-02-20 17:45 ` Dave Jiang
2025-02-11 9:53 ` [PATCH v3 18/18] cxl/acpi: Unify CFMWS memory log messages with SRAT messages Robert Richter
2025-02-14 16:37 ` Jonathan Cameron
2025-02-20 17:46 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211095349.981096-1-rrichter@amd.com \
--to=rrichter@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fabio.m.de.francesco@linux.intel.com \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=terry.bowman@amd.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox