From: alison.schofield@intel.com
To: nvdimm@lists.linux.dev
Cc: Alison Schofield <alison.schofield@intel.com>, linux-cxl@vger.kernel.org
Subject: [ndctl PATCH] cxl/test: skip, don't fail, when kernel tracing is not enabled
Date: Thu, 22 May 2025 20:15:06 -0700 [thread overview]
Message-ID: <20250523031518.1781309-1-alison.schofield@intel.com> (raw)
From: Alison Schofield <alison.schofield@intel.com>
cxl-events.sh and cxl-poison.sh require a kernel with CONFIG_TRACING
enabled and currently report a FAIL when /sys/kernel/tracing is
missing. Update these tests to report a SKIP along with a message
stating the requirement. This allows the tests to run cleanly on
systems without TRACING enabled and gives users the info needed to
enable TRACING for testing.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
Noticed this behavior in Itaru's test results:
https://lore.kernel.org/linux-cxl/FD4183E1-162E-4790-B865-E50F20249A74@linux.dev/
test/cxl-events.sh | 1 +
test/cxl-poison.sh | 1 +
2 files changed, 2 insertions(+)
diff --git a/test/cxl-events.sh b/test/cxl-events.sh
index c216d6aa9148..7326eb7447ee 100644
--- a/test/cxl-events.sh
+++ b/test/cxl-events.sh
@@ -13,6 +13,7 @@ num_info_expected=3
rc=77
set -ex
+[ -d "/sys/kernel/tracing" ] || do_skip "test requires CONFIG_TRACING"
trap 'err $LINENO' ERR
diff --git a/test/cxl-poison.sh b/test/cxl-poison.sh
index 2caf092db460..6ed890bc666c 100644
--- a/test/cxl-poison.sh
+++ b/test/cxl-poison.sh
@@ -7,6 +7,7 @@
rc=77
set -ex
+[ -d "/sys/kernel/tracing" ] || do_skip "test requires CONFIG_TRACING"
trap 'err $LINENO' ERR
--
2.37.3
next reply other threads:[~2025-05-23 3:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 3:15 alison.schofield [this message]
2025-05-23 3:57 ` [ndctl PATCH] cxl/test: skip, don't fail, when kernel tracing is not enabled Dan Williams
2025-05-23 6:00 ` Marc Herbert
2025-05-23 16:48 ` Dave Jiang
2025-05-28 20:53 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250523031518.1781309-1-alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox