Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: <alison.schofield@intel.com>, <nvdimm@lists.linux.dev>
Cc: Alison Schofield <alison.schofield@intel.com>,
	<linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH] cxl/test: skip, don't fail, when kernel tracing is not enabled
Date: Thu, 22 May 2025 20:57:49 -0700	[thread overview]
Message-ID: <682ff23d8ff_1626e100e6@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20250523031518.1781309-1-alison.schofield@intel.com>

alison.schofield@ wrote:
> From: Alison Schofield <alison.schofield@intel.com>
> 
> cxl-events.sh and cxl-poison.sh require a kernel with CONFIG_TRACING
> enabled and currently report a FAIL when /sys/kernel/tracing is
> missing. Update these tests to report a SKIP along with a message
> stating the requirement. This allows the tests to run cleanly on
> systems without TRACING enabled and gives users the info needed to
> enable TRACING for testing.
> 
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> ---
> 
> Noticed this behavior in Itaru's test results:
> https://lore.kernel.org/linux-cxl/FD4183E1-162E-4790-B865-E50F20249A74@linux.dev/

You could borrow the kernel process for information like this and move
it above the --- line with the following trailers:

Reported-by: Itaru Kitayama <itaru.kitayama@linux.dev>
Closes: http://lore.kernel.org/FD4183E1-162E-4790-B865-E50F20249A74@linux.dev

...you can also add:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

  reply	other threads:[~2025-05-23  3:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23  3:15 [ndctl PATCH] cxl/test: skip, don't fail, when kernel tracing is not enabled alison.schofield
2025-05-23  3:57 ` Dan Williams [this message]
2025-05-23  6:00 ` Marc Herbert
2025-05-23 16:48 ` Dave Jiang
2025-05-28 20:53 ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=682ff23d8ff_1626e100e6@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox