Re: [ndctl PATCH] cxl/test: skip, don't fail, when kernel tracing is not enabled

[Alison Schofield <alison.schofield@intel.com>]

On Thu, May 22, 2025 at 08:15:06PM -0700, alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
> 
> cxl-events.sh and cxl-poison.sh require a kernel with CONFIG_TRACING
> enabled and currently report a FAIL when /sys/kernel/tracing is
> missing. Update these tests to report a SKIP along with a message
> stating the requirement. This allows the tests to run cleanly on
> systems without TRACING enabled and gives users the info needed to
> enable TRACING for testing.

Applied to pending branch:
https://github.com/pmem/ndctl/tree/pending


> 
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> ---
> 
> Noticed this behavior in Itaru's test results:
> https://lore.kernel.org/linux-cxl/FD4183E1-162E-4790-B865-E50F20249A74@linux.dev/
> 
>  test/cxl-events.sh | 1 +
>  test/cxl-poison.sh | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/test/cxl-events.sh b/test/cxl-events.sh
> index c216d6aa9148..7326eb7447ee 100644
> --- a/test/cxl-events.sh
> +++ b/test/cxl-events.sh
> @@ -13,6 +13,7 @@ num_info_expected=3
>  rc=77
>  
>  set -ex
> +[ -d "/sys/kernel/tracing" ] || do_skip "test requires CONFIG_TRACING"
>  
>  trap 'err $LINENO' ERR
>  
> diff --git a/test/cxl-poison.sh b/test/cxl-poison.sh
> index 2caf092db460..6ed890bc666c 100644
> --- a/test/cxl-poison.sh
> +++ b/test/cxl-poison.sh
> @@ -7,6 +7,7 @@
>  rc=77
>  
>  set -ex
> +[ -d "/sys/kernel/tracing" ] || do_skip "test requires CONFIG_TRACING"
>  
>  trap 'err $LINENO' ERR
>  
> -- 
> 2.37.3
>