From: marc.herbert@linux.intel.com
To: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
alison.schofield@intel.com, dave.jiang@intel.com
Cc: Marc Herbert <marc.herbert@linux.intel.com>
Subject: [ndctl PATCH] test/common: document magic number CXL_TEST_QOS_CLASS=42
Date: Fri, 22 Aug 2025 02:55:34 +0000 [thread overview]
Message-ID: <20250822025533.1159539-2-marc.herbert@linux.intel.com> (raw)
From: Marc Herbert <marc.herbert@linux.intel.com>
This magic number must match kernel code. Make that corresponding kernel
code much less time-consuming to find.
Additionally, that same one-line reference indirectly documents the
minimum kernel version required by the test(s) using this value (only
cxl-qos-class.sh at this time)
Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>
---
test/common | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/common b/test/common
index 2d076402ef7c..1ab62be6994f 100644
--- a/test/common
+++ b/test/common
@@ -155,4 +155,5 @@ check_dmesg()
}
# CXL COMMON
+# Test constant defined in kernel commit v6.8-rc2-9-g117132edc690
CXL_TEST_QOS_CLASS=42
--
2.50.1
next reply other threads:[~2025-08-22 2:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 2:55 marc.herbert [this message]
2025-08-22 15:57 ` [ndctl PATCH] test/common: document magic number CXL_TEST_QOS_CLASS=42 Dave Jiang
2025-08-22 18:13 ` Alison Schofield
2025-08-23 3:07 ` Marc Herbert
2025-08-25 1:36 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822025533.1159539-2-marc.herbert@linux.intel.com \
--to=marc.herbert@linux.intel.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox