Re: [ndctl PATCH] test/common: document magic number CXL_TEST_QOS_CLASS=42

[Alison Schofield <alison.schofield@intel.com>]

On Fri, Aug 22, 2025 at 02:55:34AM +0000, marc.herbert@linux.intel.com wrote:
> From: Marc Herbert <marc.herbert@linux.intel.com>
> 
> This magic number must match kernel code. Make that corresponding kernel
> code much less time-consuming to find.

The 'must match' is the important part. Include that in the comment.
Why expect the user to parse a git describe string and go fishing.
Just tell them it is defined in the cxl-test module.

See below...

> 
> Additionally, that same one-line reference indirectly documents the
> minimum kernel version required by the test(s) using this value (only
> cxl-qos-class.sh at this time)
> 
> Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>
> ---
>  test/common | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/common b/test/common
> index 2d076402ef7c..1ab62be6994f 100644
> --- a/test/common
> +++ b/test/common
> @@ -155,4 +155,5 @@ check_dmesg()
>  }
>  
>  # CXL COMMON
> +# Test constant defined in kernel commit v6.8-rc2-9-g117132edc690

# Must match the FAKE_QTG_ID defined in the cxl-test module

>  CXL_TEST_QOS_CLASS=42
> -- 
> 2.50.1
>