Linux CXL
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: marc.herbert@linux.intel.com, linux-cxl@vger.kernel.org,
	nvdimm@lists.linux.dev, alison.schofield@intel.com
Subject: Re: [ndctl PATCH] test/common: document magic number CXL_TEST_QOS_CLASS=42
Date: Fri, 22 Aug 2025 08:57:21 -0700	[thread overview]
Message-ID: <c3b27607-6878-4dd6-875d-532850577527@intel.com> (raw)
In-Reply-To: <20250822025533.1159539-2-marc.herbert@linux.intel.com>



On 8/21/25 7:55 PM, marc.herbert@linux.intel.com wrote:
> From: Marc Herbert <marc.herbert@linux.intel.com>
> 
> This magic number must match kernel code. Make that corresponding kernel
> code much less time-consuming to find.
> 
> Additionally, that same one-line reference indirectly documents the
> minimum kernel version required by the test(s) using this value (only
> cxl-qos-class.sh at this time)
> 
> Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  test/common | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/common b/test/common
> index 2d076402ef7c..1ab62be6994f 100644
> --- a/test/common
> +++ b/test/common
> @@ -155,4 +155,5 @@ check_dmesg()
>  }
>  
>  # CXL COMMON
> +# Test constant defined in kernel commit v6.8-rc2-9-g117132edc690
>  CXL_TEST_QOS_CLASS=42


  reply	other threads:[~2025-08-22 15:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  2:55 [ndctl PATCH] test/common: document magic number CXL_TEST_QOS_CLASS=42 marc.herbert
2025-08-22 15:57 ` Dave Jiang [this message]
2025-08-22 18:13 ` Alison Schofield
2025-08-23  3:07   ` Marc Herbert
2025-08-25  1:36     ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3b27607-6878-4dd6-875d-532850577527@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=marc.herbert@linux.intel.com \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox