Re: [PATCH v31 2/5] sfc: Map cxl regs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit adds `#include <cxl/pci.h>`, but `include/cxl/pci.h` does not exist in the kernel tree, resulting in a fatal compilation error.
--

commit fd1792aaa5cf6782d5137f23ed3db63b260303d5
Author: Alejandro Lucero <alucerop@amd.com>

sfc: Map cxl regs

This commit introduces CXL core functions to the SFC driver for discovering
and mapping CXL device registers. It sets up the component registers and
verifies the presence of HDM and RAS capabilities.

> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> index be252af972ab3..704b0ebae9374 100644
> --- a/drivers/net/ethernet/sfc/efx_cxl.c
> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> @@ -7,6 +7,8 @@
>  
>  #include <linux/pci.h>
>  
> +#include <cxl/cxl.h>
> +#include <cxl/pci.h>

[Severity: Low]
Is this the correct header path? The cxl/pci.h file doesn't appear to exist
in the kernel tree. The cxl_pci_setup_regs() function and the
CXL_REGLOC_RBI_COMPONENT enum seem to be defined in drivers/cxl/cxlpci.h,
which is internal to the CXL subsystem and not exposed to other drivers.
Will this cause a build failure when compiling the sfc driver?

[ ... ]

> @@ -42,6 +45,29 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  	if (!cxl)
>  		return -ENOMEM;
>  
> +	rc = cxl_pci_setup_regs(pci_dev, CXL_REGLOC_RBI_COMPONENT,
> +				&cxl->cxlds.reg_map);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630151346.31201-1-alejandro.lucero-palau@amd.com?part=2