Re: [PATCH v31 3/5] sfc: Initialize cxl dpa

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The patch adds a call to an undefined function `cxl_set_capacity()`, which will cause a build failure.
- [Low] The file includes `<cxl/pci.h>` which does not exist in the source tree, causing a build failure.
--

commit 658adf5bd8fde62f9bb534a3960bfeef69a61055
Author: Alejandro Lucero <alucerop@amd.com>

sfc: Initialize cxl dpa

Use cxl_set_capacity() for DPA initialization as no mailbox is
available.

> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> index 704b0ebae9374..18b535b3ea405 100644
> --- a/drivers/net/ethernet/sfc/efx_cxl.c
> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> @@ -68,6 +68,11 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  	 */
>  	cxl->cxlds.media_ready = true;
>  
> +	if (cxl_set_capacity(&cxl->cxlds, EFX_CTPIO_BUFFER_SIZE)) {

[Severity: Low]
Are we calling an undefined function here? cxl_set_capacity() is neither
declared nor defined anywhere in the kernel source tree, which causes a build
failure.

> +		pci_err(pci_dev, "dpa capacity setup failed\n");
> +		return -ENODEV;
> +	}
> +
>  	probe_data->cxl = cxl;
>  
>  	return 0;

[Severity: Low]
Is there a missing header file in this file? It includes <cxl/pci.h> which
does not exist in the kernel tree, causing a fatal compilation error:

drivers/net/ethernet/sfc/efx_cxl.c:
    ...
    #include <linux/pci.h>

    #include <cxl/cxl.h>
    #include <cxl/pci.h>
    #include "net_driver.h"
    ...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630151346.31201-1-alejandro.lucero-palau@amd.com?part=3