From: Davidlohr Bueso <dave@stgolabs.net>
To: Jonathan Cameron <jic23@kernel.org>
Cc: dave.jiang@intel.com, alison.schofield@intel.com,
icheng@nvidia.com, ming.li@zohomail.com,
benjamin.cheatham@amd.com, alucerop@amd.com,
linux-cxl@vger.kernel.org
Subject: Re: [PATCH v8 07/10] cxl/pci: Split BI capability probe from setup
Date: Wed, 9 Sep 2026 14:45:37 -0700 [thread overview]
Message-ID: <20260909214537.7xt6ixzztbes4wkn@offworld> (raw)
In-Reply-To: <20260909224037.7bd984d5@jic23-hlaptop>
On Wed, 09 Sep 2026, Jonathan Cameron wrote:
>> +void cxl_bi_reset_detected(struct cxl_port *endpoint)
>> +{
>> + struct cxl_memdev *cxlmd = to_cxl_memdev(endpoint->uport_dev);
>> + struct cxl_dev_state *cxlds = cxlmd->cxlds;
>> + void __iomem *bi = endpoint->regs.bi_decoder;
>> +
>> + if (!cxlds->bi)
>> + return;
>> +
>> + if (FIELD_GET(CXL_BI_DECODER_CTRL_BI_ENABLE,
>> + readl(bi + CXL_BI_DECODER_CTRL_OFFSET)))
>> + return;
>> +
>> + dev_dbg(cxlds->dev, "BI disabled by reset\n");
>> + cxlds->bi = false;
>> +}
>> +EXPORT_SYMBOL_NS_GPL(cxl_bi_reset_detected, "CXL");
>
>Why did this need to move? Just to have a nicer code arrangement?
>Maybe not worth it given it makes it look like this changed
>and it didn't. I'd leave it where diff thinks it was originally.
Oh silly me, yes I will be dropped for v9. Sorry for the noise.
Thanks,
Davidlohr
next prev parent reply other threads:[~2026-09-09 21:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 17:02 [PATCH v8 0/10] cxl: Support Back-Invalidate Davidlohr Bueso
2026-09-09 17:02 ` [PATCH v8 01/10] cxl: Add BI register probing and port initialization Davidlohr Bueso
2026-09-09 19:38 ` Jonathan Cameron
2026-09-09 17:02 ` [PATCH v8 02/10] cxl/pci: Add BI topology enable/disable Davidlohr Bueso
2026-09-09 21:21 ` Jonathan Cameron
2026-09-10 1:33 ` Davidlohr Bueso
2026-09-10 2:40 ` Li Ming
2026-09-09 17:02 ` [PATCH v8 03/10] cxl/hdm: Add BI coherency support for endpoint decoders Davidlohr Bueso
2026-09-09 21:27 ` Jonathan Cameron
2026-09-09 17:02 ` [PATCH v8 04/10] cxl: Add HDM-DB region creation Davidlohr Bueso
2026-09-09 17:48 ` sashiko-bot
2026-09-09 21:31 ` Jonathan Cameron
2026-09-09 17:02 ` [PATCH v8 05/10] cxl/hdm: Rename decoder coherency flags Davidlohr Bueso
2026-09-09 21:32 ` Jonathan Cameron
2026-09-09 17:02 ` [PATCH v8 06/10] cxl/region: Log the coherency model at region creation Davidlohr Bueso
2026-09-09 21:32 ` Jonathan Cameron
2026-09-09 17:02 ` [PATCH v8 07/10] cxl/pci: Split BI capability probe from setup Davidlohr Bueso
2026-09-09 21:40 ` Jonathan Cameron
2026-09-09 21:45 ` Davidlohr Bueso [this message]
2026-09-09 17:03 ` [PATCH v8 08/10] cxl: Allow auto-committed BI hdm decoders Davidlohr Bueso
2026-09-09 21:45 ` Jonathan Cameron
2026-09-10 11:38 ` Li Ming
2026-09-09 17:03 ` [PATCH v8 09/10] cxl/test: Add mock BI topology support Davidlohr Bueso
2026-09-09 21:49 ` Jonathan Cameron
2026-09-09 22:08 ` Davidlohr Bueso
2026-09-09 17:03 ` [PATCH v8 10/10] cxl/doc: Update maturity map with BI support Davidlohr Bueso
2026-09-09 21:50 ` Jonathan Cameron
2026-09-09 18:47 ` [PATCH v8 0/10] cxl: Support Back-Invalidate Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909214537.7xt6ixzztbes4wkn@offworld \
--to=dave@stgolabs.net \
--cc=alison.schofield@intel.com \
--cc=alucerop@amd.com \
--cc=benjamin.cheatham@amd.com \
--cc=dave.jiang@intel.com \
--cc=icheng@nvidia.com \
--cc=jic23@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=ming.li@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox