From: Dave Jiang <dave.jiang@intel.com>
To: Li Zhijian <lizhijian@fujitsu.com>, <nvdimm@lists.linux.dev>
Cc: <linux-cxl@vger.kernel.org>, <alison.schofield@intel.com>
Subject: Re: [ndctl PATCH v3 4/6] cxl/monitor: always log started message
Date: Wed, 5 Jul 2023 11:21:06 -0700 [thread overview]
Message-ID: <292a06e8-c7ba-3a40-71bd-406dc7d37e41@intel.com> (raw)
In-Reply-To: <20230531021936.7366-5-lizhijian@fujitsu.com>
On 5/30/23 19:19, Li Zhijian wrote:
> Tell people monitor is starting rather only daemon mode will log this
> message before. It's a minor fix so that whatever stdout or logfile
> is specified, people can see a *normal* message.
>
> After this patch
> # cxl monitor
> cxl monitor started.
> ^C
> # cxl monitor -l standard.log
> ^C
> # cat standard.log
> [1684735993.704815571] [818499] cxl monitor started.
> # cxl monitor --daemon -l /var/log/daemon.log
> # cat /var/log/daemon.log
> [1684736075.817150494] [818509] cxl monitor started.
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> V2: commit log updated # Dave
> ---
> cxl/monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cxl/monitor.c b/cxl/monitor.c
> index 179646562187..0736483cc50a 100644
> --- a/cxl/monitor.c
> +++ b/cxl/monitor.c
> @@ -205,8 +205,8 @@ int cmd_monitor(int argc, const char **argv, struct cxl_ctx *ctx)
> err(&monitor, "daemon start failed\n");
> goto out;
> }
> - info(&monitor, "cxl monitor daemon started.\n");
> }
> + info(&monitor, "cxl monitor started.\n");
>
> rc = monitor_event(ctx);
>
next prev parent reply other threads:[~2023-07-05 18:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 2:19 [ndctl PATCH v3 0/6] cxl/monitor and ndctl/monitor fixes Li Zhijian
2023-05-31 2:19 ` [ndctl PATCH v3 1/6] cxl/monitor: Enable default_log and refactor sanity check Li Zhijian
2023-07-05 17:45 ` Dave Jiang
2023-07-05 20:53 ` Verma, Vishal L
2023-07-10 10:53 ` Zhijian Li (Fujitsu)
2023-07-10 16:59 ` Verma, Vishal L
2023-05-31 2:19 ` [ndctl PATCH v3 2/6] cxl/monitor: replace monitor.log_file with monitor.ctx.log_file Li Zhijian
2023-07-05 17:46 ` Dave Jiang
2023-05-31 2:19 ` [ndctl PATCH v3 3/6] cxl/monitor: use strcmp to compare the reserved word Li Zhijian
2023-07-05 18:20 ` Dave Jiang
2023-07-05 21:03 ` Verma, Vishal L
2023-07-10 12:53 ` Zhijian Li (Fujitsu)
2023-05-31 2:19 ` [ndctl PATCH v3 4/6] cxl/monitor: always log started message Li Zhijian
2023-07-05 18:21 ` Dave Jiang [this message]
2023-07-05 21:16 ` Verma, Vishal L
2023-07-10 13:05 ` Zhijian Li (Fujitsu)
2023-05-31 2:19 ` [ndctl PATCH v3 5/6] Documentation/cxl/cxl-monitor.txt: Fix inaccurate description Li Zhijian
2023-05-31 2:19 ` [ndctl PATCH v3 6/6] ndctl/monitor: use strcmp to compare the reserved word Li Zhijian
2023-07-05 18:22 ` Dave Jiang
2023-06-27 10:17 ` [ndctl PATCH v3 0/6] cxl/monitor and ndctl/monitor fixes Zhijian Li (Fujitsu)
2023-07-05 21:21 ` Verma, Vishal L
2023-07-05 23:53 ` Alison Schofield
2023-07-10 13:06 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292a06e8-c7ba-3a40-71bd-406dc7d37e41@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox