From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Cc: "Jiang, Dave" <dave.jiang@intel.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"Schofield, Alison" <alison.schofield@intel.com>
Subject: Re: [ndctl PATCH v3 1/6] cxl/monitor: Enable default_log and refactor sanity check
Date: Mon, 10 Jul 2023 16:59:17 +0000 [thread overview]
Message-ID: <49b68658b6abb3f36823507a18692ea3af1afb02.camel@intel.com> (raw)
In-Reply-To: <895193f2-6d4e-e481-69ca-74ac2c0fee5f@fujitsu.com>
On Mon, 2023-07-10 at 10:53 +0000, Zhijian Li (Fujitsu) wrote:
> > >
> > > log_init(&monitor.ctx, "cxl/monitor",
> > > "CXL_MONITOR_LOG");
> > > - monitor.ctx.log_fn = log_standard;
> > > + if (monitor.log)
> > > + log = monitor.log;
> > > + else
> > > + log = monitor.daemon ? default_log :
> > > "./standard";
> >
> > I think the original './standard' was used that way because
> > fix_filename() added the './' prefix.
>
> At present, './' will still be added by parse_options_prefix() at the
> beginning.
>
Ah yes I missed this - I must've confused my test attempts - you're
right, 'standard' behaves as expected (stdout) and './standard also
works as expected (creates a file called standard in the cwd).
next prev parent reply other threads:[~2023-07-10 16:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 2:19 [ndctl PATCH v3 0/6] cxl/monitor and ndctl/monitor fixes Li Zhijian
2023-05-31 2:19 ` [ndctl PATCH v3 1/6] cxl/monitor: Enable default_log and refactor sanity check Li Zhijian
2023-07-05 17:45 ` Dave Jiang
2023-07-05 20:53 ` Verma, Vishal L
2023-07-10 10:53 ` Zhijian Li (Fujitsu)
2023-07-10 16:59 ` Verma, Vishal L [this message]
2023-05-31 2:19 ` [ndctl PATCH v3 2/6] cxl/monitor: replace monitor.log_file with monitor.ctx.log_file Li Zhijian
2023-07-05 17:46 ` Dave Jiang
2023-05-31 2:19 ` [ndctl PATCH v3 3/6] cxl/monitor: use strcmp to compare the reserved word Li Zhijian
2023-07-05 18:20 ` Dave Jiang
2023-07-05 21:03 ` Verma, Vishal L
2023-07-10 12:53 ` Zhijian Li (Fujitsu)
2023-05-31 2:19 ` [ndctl PATCH v3 4/6] cxl/monitor: always log started message Li Zhijian
2023-07-05 18:21 ` Dave Jiang
2023-07-05 21:16 ` Verma, Vishal L
2023-07-10 13:05 ` Zhijian Li (Fujitsu)
2023-05-31 2:19 ` [ndctl PATCH v3 5/6] Documentation/cxl/cxl-monitor.txt: Fix inaccurate description Li Zhijian
2023-05-31 2:19 ` [ndctl PATCH v3 6/6] ndctl/monitor: use strcmp to compare the reserved word Li Zhijian
2023-07-05 18:22 ` Dave Jiang
2023-06-27 10:17 ` [ndctl PATCH v3 0/6] cxl/monitor and ndctl/monitor fixes Zhijian Li (Fujitsu)
2023-07-05 21:21 ` Verma, Vishal L
2023-07-05 23:53 ` Alison Schofield
2023-07-10 13:06 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49b68658b6abb3f36823507a18692ea3af1afb02.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox