Linux CXL
 help / color / mirror / Atom feed
From: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
To: "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
	"dave.jiang@intel.com" <dave.jiang@intel.com>,
	"alison.schofield@intel.com" <alison.schofield@intel.com>
Subject: Re: [ndctl PATCH v3 0/6] cxl/monitor and ndctl/monitor fixes
Date: Tue, 27 Jun 2023 10:17:20 +0000	[thread overview]
Message-ID: <f83e918e-ae85-cbfd-dd3a-0ef3f1519cd7@fujitsu.com> (raw)
In-Reply-To: <20230531021936.7366-1-lizhijian@fujitsu.com>

kindly ping

It has been almost a month, and it's doing some bugfix. The progress is a little bit slow anyway :)



On 31/05/2023 10:19, Li Zhijian wrote:
> V3:
> - update comit log of patch3 and patch6 per Dave's comments.
> 
> V2:
> - exchange order of previous patch1 and patch2
> - add reviewed tag in patch5
> - commit log improvements
> 
> It mainly fix monitor not working when log file is specified. For
> example
> $ cxl monitor -l ./cxl-monitor.log
> It seems that someone missed something at the begining.
> 
> Future, it compares the filename with reserved word more accurately
> 
> patch1-2: It re-enables logfile(including default_log) functionality
> and simplify the sanity check in the combination relative path file
> and daemon mode.
> 
> patch3 and patch6 change strncmp to strcmp to compare the acurrate
> reserved words.
> 
> Li Zhijian (6):
>    cxl/monitor: Enable default_log and refactor sanity check
>    cxl/monitor: replace monitor.log_file with monitor.ctx.log_file
>    cxl/monitor: use strcmp to compare the reserved word
>    cxl/monitor: always log started message
>    Documentation/cxl/cxl-monitor.txt: Fix inaccurate description
>    ndctl/monitor: use strcmp to compare the reserved word
> 
>   Documentation/cxl/cxl-monitor.txt |  3 +--
>   cxl/monitor.c                     | 45 ++++++++++++++++---------------
>   ndctl/monitor.c                   |  4 +--
>   3 files changed, 26 insertions(+), 26 deletions(-)
> 

  parent reply	other threads:[~2023-06-27 10:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31  2:19 [ndctl PATCH v3 0/6] cxl/monitor and ndctl/monitor fixes Li Zhijian
2023-05-31  2:19 ` [ndctl PATCH v3 1/6] cxl/monitor: Enable default_log and refactor sanity check Li Zhijian
2023-07-05 17:45   ` Dave Jiang
2023-07-05 20:53   ` Verma, Vishal L
2023-07-10 10:53     ` Zhijian Li (Fujitsu)
2023-07-10 16:59       ` Verma, Vishal L
2023-05-31  2:19 ` [ndctl PATCH v3 2/6] cxl/monitor: replace monitor.log_file with monitor.ctx.log_file Li Zhijian
2023-07-05 17:46   ` Dave Jiang
2023-05-31  2:19 ` [ndctl PATCH v3 3/6] cxl/monitor: use strcmp to compare the reserved word Li Zhijian
2023-07-05 18:20   ` Dave Jiang
2023-07-05 21:03   ` Verma, Vishal L
2023-07-10 12:53     ` Zhijian Li (Fujitsu)
2023-05-31  2:19 ` [ndctl PATCH v3 4/6] cxl/monitor: always log started message Li Zhijian
2023-07-05 18:21   ` Dave Jiang
2023-07-05 21:16   ` Verma, Vishal L
2023-07-10 13:05     ` Zhijian Li (Fujitsu)
2023-05-31  2:19 ` [ndctl PATCH v3 5/6] Documentation/cxl/cxl-monitor.txt: Fix inaccurate description Li Zhijian
2023-05-31  2:19 ` [ndctl PATCH v3 6/6] ndctl/monitor: use strcmp to compare the reserved word Li Zhijian
2023-07-05 18:22   ` Dave Jiang
2023-06-27 10:17 ` Zhijian Li (Fujitsu) [this message]
2023-07-05 21:21   ` [ndctl PATCH v3 0/6] cxl/monitor and ndctl/monitor fixes Verma, Vishal L
2023-07-05 23:53 ` Alison Schofield
2023-07-10 13:06   ` Zhijian Li (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f83e918e-ae85-cbfd-dd3a-0ef3f1519cd7@fujitsu.com \
    --to=lizhijian@fujitsu.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox