Re: [PATCH V2 02/20] nvdimm/label: Prep patch to accommodate cxl lsa 2.1 support

[Ira Weiny <ira.weiny@intel.com>]

Neeraj Kumar wrote:
> LSA 2.1 format introduces region label, which can also reside
> into LSA along with only namespace label as per v1.1 and v1.2
> 
> As both namespace and region labels are of same size of 256 bytes.

Soft-NAK

Having 2 data structures of the same size is not a reason to combine their
types.

Please explain how nd_namespace_label is related to the new region label
and why combining them is a net benefit.  This change may need to be made
later in the series if that makes it more understandable.

> Thus renamed "struct nd_namespace_label" to "struct nd_lsa_label",
> where both namespace label and region label can stay as union.

For now I'm naking this patch unless there is some justification for
changing all the names vs just introducing "nd_region_label" or whatever
it might need to be named.

Ira

> 
> No functional change introduced.
> 
> Signed-off-by: Neeraj Kumar <s.neeraj@samsung.com>

[snip]