Re: [PATCH v14 01/22] cxl: add type2 device basic support

[Alejandro Lucero Palau <alucerop@amd.com>]

On 5/7/25 15:37, Jonathan Cameron wrote:
> On Thu, 17 Apr 2025 22:29:04 +0100
> <alejandro.lucero-palau@amd.com> wrote:
>
>> diff --git a/include/cxl/cxl.h b/include/cxl/cxl.h
>> new file mode 100644
>> index 000000000000..a8ffcc5c2b32
>> --- /dev/null
>> +++ b/include/cxl/cxl.h
>> @@ -0,0 +1,210 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/* Copyright(c) 2020 Intel Corporation. */
>> +/* Copyright(c) 2025 Advanced Micro Devices, Inc. */
>> +
>> +#ifndef __CXL_CXL_H__
>> +#define __CXL_CXL_H__
>> +
>> +#include <linux/cdev.h>
> Why this include?  Maybe needed in a later patch?


Good catch. It seems it is not needed.

Removing it.

Thanks!


>> +#include <linux/node.h>
>> +#include <linux/ioport.h>
>> +#include <cxl/mailbox.h>