From: alison.schofield@intel.com
To: Ben Widawsky <ben.widawsky@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: [ndctl PATCH 1/7] libcxl: add GET_PARTITION_INFO mailbox command and accessors
Date: Mon, 3 Jan 2022 12:16:12 -0800 [thread overview]
Message-ID: <9d3c55cbd36efb6eabec075cc8596a6382f1f145.1641233076.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1641233076.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
Add libcxl APIs to create a new GET_PARTITION_INFO mailbox command, the
command output data structure (privately), and accessor APIs to return
the different fields in the partition info output.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
cxl/lib/private.h | 10 ++++++++++
cxl/libcxl.h | 5 +++++
util/size.h | 1 +
cxl/lib/libcxl.c | 41 +++++++++++++++++++++++++++++++++++++++++
cxl/lib/libcxl.sym | 5 +++++
5 files changed, 62 insertions(+)
diff --git a/cxl/lib/private.h b/cxl/lib/private.h
index a1b8b50..dd9234f 100644
--- a/cxl/lib/private.h
+++ b/cxl/lib/private.h
@@ -7,6 +7,7 @@
#include <cxl/cxl_mem.h>
#include <ccan/endian/endian.h>
#include <ccan/short_types/short_types.h>
+#include <util/size.h>
#define CXL_EXPORT __attribute__ ((visibility("default")))
@@ -104,6 +105,15 @@ struct cxl_cmd_get_health_info {
le32 pmem_errors;
} __attribute__((packed));
+struct cxl_cmd_get_partition_info {
+ le64 active_volatile_cap;
+ le64 active_persistent_cap;
+ le64 next_volatile_cap;
+ le64 next_persistent_cap;
+} __attribute__((packed));
+
+#define CXL_CAPACITY_MULTIPLIER SZ_256M
+
/* CXL 2.0 8.2.9.5.3 Byte 0 Health Status */
#define CXL_CMD_HEALTH_INFO_STATUS_MAINTENANCE_NEEDED_MASK BIT(0)
#define CXL_CMD_HEALTH_INFO_STATUS_PERFORMANCE_DEGRADED_MASK BIT(1)
diff --git a/cxl/libcxl.h b/cxl/libcxl.h
index 89d35ba..7cf9061 100644
--- a/cxl/libcxl.h
+++ b/cxl/libcxl.h
@@ -109,6 +109,11 @@ ssize_t cxl_cmd_read_label_get_payload(struct cxl_cmd *cmd, void *buf,
unsigned int length);
struct cxl_cmd *cxl_cmd_new_write_label(struct cxl_memdev *memdev,
void *buf, unsigned int offset, unsigned int length);
+struct cxl_cmd *cxl_cmd_new_get_partition_info(struct cxl_memdev *memdev);
+unsigned long long cxl_cmd_get_partition_info_get_active_volatile_cap(struct cxl_cmd *cmd);
+unsigned long long cxl_cmd_get_partition_info_get_active_persistent_cap(struct cxl_cmd *cmd);
+unsigned long long cxl_cmd_get_partition_info_get_next_volatile_cap(struct cxl_cmd *cmd);
+unsigned long long cxl_cmd_get_partition_info_get_next_persistent_cap(struct cxl_cmd *cmd);
#ifdef __cplusplus
} /* extern "C" */
diff --git a/util/size.h b/util/size.h
index a0f3593..e72467f 100644
--- a/util/size.h
+++ b/util/size.h
@@ -15,6 +15,7 @@
#define SZ_4M 0x00400000
#define SZ_16M 0x01000000
#define SZ_64M 0x04000000
+#define SZ_256M 0x10000000
#define SZ_1G 0x40000000
#define SZ_1T 0x10000000000ULL
diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
index f0664be..f3d4022 100644
--- a/cxl/lib/libcxl.c
+++ b/cxl/lib/libcxl.c
@@ -1157,6 +1157,47 @@ CXL_EXPORT ssize_t cxl_cmd_read_label_get_payload(struct cxl_cmd *cmd,
return length;
}
+CXL_EXPORT struct cxl_cmd *cxl_cmd_new_get_partition_info(struct cxl_memdev *memdev)
+{
+ return cxl_cmd_new_generic(memdev,
+ CXL_MEM_COMMAND_ID_GET_PARTITION_INFO);
+}
+
+#define cmd_partition_get_capacity_field(cmd, field) \
+do { \
+ struct cxl_cmd_get_partition_info *c = \
+ (struct cxl_cmd_get_partition_info *)cmd->send_cmd->out.payload;\
+ int rc = cxl_cmd_validate_status(cmd, \
+ CXL_MEM_COMMAND_ID_GET_PARTITION_INFO); \
+ if (rc) \
+ return ULLONG_MAX; \
+ return le64_to_cpu(c->field) * CXL_CAPACITY_MULTIPLIER; \
+} while (0)
+
+CXL_EXPORT unsigned long long
+cxl_cmd_get_partition_info_get_active_volatile_cap(struct cxl_cmd *cmd)
+{
+ cmd_partition_get_capacity_field(cmd, active_volatile_cap);
+}
+
+CXL_EXPORT unsigned long long
+cxl_cmd_get_partition_info_get_active_persistent_cap(struct cxl_cmd *cmd)
+{
+ cmd_partition_get_capacity_field(cmd, active_persistent_cap);
+}
+
+CXL_EXPORT unsigned long long
+cxl_cmd_get_partition_info_get_next_volatile_cap(struct cxl_cmd *cmd)
+{
+ cmd_partition_get_capacity_field(cmd, next_volatile_cap);
+}
+
+CXL_EXPORT unsigned long long
+cxl_cmd_get_partition_info_get_next_persistent_cap(struct cxl_cmd *cmd)
+{
+ cmd_partition_get_capacity_field(cmd, next_persistent_cap);
+}
+
CXL_EXPORT int cxl_cmd_submit(struct cxl_cmd *cmd)
{
struct cxl_memdev *memdev = cmd->memdev;
diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
index 077d104..09d6d94 100644
--- a/cxl/lib/libcxl.sym
+++ b/cxl/lib/libcxl.sym
@@ -70,6 +70,11 @@ global:
cxl_memdev_zero_label;
cxl_memdev_write_label;
cxl_memdev_read_label;
+ cxl_cmd_new_get_partition_info;
+ cxl_cmd_get_partition_info_get_active_volatile_cap;
+ cxl_cmd_get_partition_info_get_active_persistent_cap;
+ cxl_cmd_get_partition_info_get_next_volatile_cap;
+ cxl_cmd_get_partition_info_get_next_persistent_cap;
local:
*;
};
--
2.31.1
next prev parent reply other threads:[~2022-01-03 20:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 20:16 [ndctl PATCH 0/7] Add partitioning support for CXL memdevs alison.schofield
2022-01-03 20:16 ` alison.schofield [this message]
2022-01-06 20:19 ` [ndctl PATCH 1/7] libcxl: add GET_PARTITION_INFO mailbox command and accessors Ira Weiny
2022-01-06 21:21 ` Dan Williams
2022-01-06 21:30 ` Ira Weiny
2022-01-06 21:57 ` Verma, Vishal L
2022-01-07 20:27 ` Alison Schofield
2022-01-07 19:56 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 2/7] libcxl: add accessors for capacity fields of the IDENTIFY command alison.schofield
2022-01-06 20:36 ` Ira Weiny
2022-01-07 20:25 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 3/7] libcxl: apply CXL_CAPACITY_MULTIPLIER to partition alignment field alison.schofield
2022-01-06 20:40 ` Ira Weiny
2022-01-07 20:01 ` Verma, Vishal L
2022-01-03 20:16 ` [ndctl PATCH 4/7] cxl: add memdev partition information to cxl-list alison.schofield
2022-01-06 20:49 ` Ira Weiny
2022-01-07 20:52 ` Alison Schofield
2022-01-06 21:51 ` Dan Williams
2022-01-07 20:32 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 5/7] libcxl: add interfaces for SET_PARTITION_INFO mailbox command alison.schofield
2022-01-06 20:53 ` Ira Weiny
2022-01-08 1:51 ` Alison Schofield
2022-01-08 2:27 ` Dan Williams
2022-01-10 2:13 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 6/7] ndctl, util: use 'unsigned long long' type in OPT_U64 define alison.schofield
2022-01-06 20:54 ` Ira Weiny
2022-01-07 20:59 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 7/7] cxl: add command set-partition-info alison.schofield
2022-01-06 21:05 ` Ira Weiny
2022-01-07 22:51 ` Alison Schofield
2022-01-06 21:35 ` Dan Williams
2022-01-07 22:46 ` Alison Schofield
2022-01-06 22:19 ` Dan Williams
2022-01-07 22:45 ` Alison Schofield
2022-01-10 21:37 ` Alison Schofield
2022-01-06 20:32 ` [ndctl PATCH 0/7] Add partitioning support for CXL memdevs Ira Weiny
2022-01-07 19:44 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d3c55cbd36efb6eabec075cc8596a6382f1f145.1641233076.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox