From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"Schofield, Alison" <alison.schofield@intel.com>,
"Widawsky, Ben" <ben.widawsky@intel.com>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH 1/7] libcxl: add GET_PARTITION_INFO mailbox command and accessors
Date: Thu, 6 Jan 2022 21:57:59 +0000 [thread overview]
Message-ID: <a964f28b2541168b94ed732f658980fc87954391.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4h4_V+fugcbU0f_+ZJ9sALdDqAtgovoVhpjzd6cYiBHgA@mail.gmail.com>
On Thu, 2022-01-06 at 13:21 -0800, Dan Williams wrote:
> On Thu, Jan 6, 2022 at 12:19 PM Ira Weiny <ira.weiny@intel.com> wrote:
> >
[..]
> > > +struct cxl_cmd *cxl_cmd_new_get_partition_info(struct cxl_memdev *memdev);
> >
> > why 'new'? Why not:
> >
> > cxl_cmd_get_partition_info()
> >
> > ?
>
> The "new" is the naming convention inherited from ndctl indicating the
> allocation of a new command object. The motivation is to have a verb /
> action in all of the APIs.
>
> >
> > > +unsigned long long cxl_cmd_get_partition_info_get_active_volatile_cap(struct cxl_cmd *cmd);
> > > +unsigned long long cxl_cmd_get_partition_info_get_active_persistent_cap(struct cxl_cmd *cmd);
> > > +unsigned long long cxl_cmd_get_partition_info_get_next_volatile_cap(struct cxl_cmd *cmd);
> > > +unsigned long long cxl_cmd_get_partition_info_get_next_persistent_cap(struct cxl_cmd *cmd);
Just one nit here about the double verb 'get'. In such cases,
get_partition_info can just become 'partition_info'
e.g.: cxl_cmd_partition_info_get_active_volatile_cap(...
>
next prev parent reply other threads:[~2022-01-06 21:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 20:16 [ndctl PATCH 0/7] Add partitioning support for CXL memdevs alison.schofield
2022-01-03 20:16 ` [ndctl PATCH 1/7] libcxl: add GET_PARTITION_INFO mailbox command and accessors alison.schofield
2022-01-06 20:19 ` Ira Weiny
2022-01-06 21:21 ` Dan Williams
2022-01-06 21:30 ` Ira Weiny
2022-01-06 21:57 ` Verma, Vishal L [this message]
2022-01-07 20:27 ` Alison Schofield
2022-01-07 19:56 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 2/7] libcxl: add accessors for capacity fields of the IDENTIFY command alison.schofield
2022-01-06 20:36 ` Ira Weiny
2022-01-07 20:25 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 3/7] libcxl: apply CXL_CAPACITY_MULTIPLIER to partition alignment field alison.schofield
2022-01-06 20:40 ` Ira Weiny
2022-01-07 20:01 ` Verma, Vishal L
2022-01-03 20:16 ` [ndctl PATCH 4/7] cxl: add memdev partition information to cxl-list alison.schofield
2022-01-06 20:49 ` Ira Weiny
2022-01-07 20:52 ` Alison Schofield
2022-01-06 21:51 ` Dan Williams
2022-01-07 20:32 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 5/7] libcxl: add interfaces for SET_PARTITION_INFO mailbox command alison.schofield
2022-01-06 20:53 ` Ira Weiny
2022-01-08 1:51 ` Alison Schofield
2022-01-08 2:27 ` Dan Williams
2022-01-10 2:13 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 6/7] ndctl, util: use 'unsigned long long' type in OPT_U64 define alison.schofield
2022-01-06 20:54 ` Ira Weiny
2022-01-07 20:59 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 7/7] cxl: add command set-partition-info alison.schofield
2022-01-06 21:05 ` Ira Weiny
2022-01-07 22:51 ` Alison Schofield
2022-01-06 21:35 ` Dan Williams
2022-01-07 22:46 ` Alison Schofield
2022-01-06 22:19 ` Dan Williams
2022-01-07 22:45 ` Alison Schofield
2022-01-10 21:37 ` Alison Schofield
2022-01-06 20:32 ` [ndctl PATCH 0/7] Add partitioning support for CXL memdevs Ira Weiny
2022-01-07 19:44 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a964f28b2541168b94ed732f658980fc87954391.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox