From: alison.schofield@intel.com
To: Ben Widawsky <ben.widawsky@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: [ndctl PATCH 5/7] libcxl: add interfaces for SET_PARTITION_INFO mailbox command
Date: Mon, 3 Jan 2022 12:16:16 -0800 [thread overview]
Message-ID: <fa45e95e5d28981b4ec41db65aab82c103bff0c3.1641233076.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1641233076.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
Add APIs to allocate and send a SET_PARTITION_INFO mailbox command.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
cxl/lib/private.h | 9 +++++++++
cxl/libcxl.h | 4 ++++
cxl/lib/libcxl.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
cxl/lib/libcxl.sym | 3 +++
4 files changed, 61 insertions(+)
diff --git a/cxl/lib/private.h b/cxl/lib/private.h
index dd9234f..841aa80 100644
--- a/cxl/lib/private.h
+++ b/cxl/lib/private.h
@@ -114,6 +114,15 @@ struct cxl_cmd_get_partition_info {
#define CXL_CAPACITY_MULTIPLIER SZ_256M
+struct cxl_cmd_set_partition_info {
+ le64 volatile_capacity;
+ u8 flags;
+} __attribute__((packed));
+
+/* CXL 2.0 8.2.9.5.2 Set Partition Info */
+#define CXL_CMD_SET_PARTITION_INFO_NO_FLAG (0)
+#define CXL_CMD_SET_PARTITION_INFO_IMMEDIATE_FLAG (1)
+
/* CXL 2.0 8.2.9.5.3 Byte 0 Health Status */
#define CXL_CMD_HEALTH_INFO_STATUS_MAINTENANCE_NEEDED_MASK BIT(0)
#define CXL_CMD_HEALTH_INFO_STATUS_PERFORMANCE_DEGRADED_MASK BIT(1)
diff --git a/cxl/libcxl.h b/cxl/libcxl.h
index d333b6d..67d6ffc 100644
--- a/cxl/libcxl.h
+++ b/cxl/libcxl.h
@@ -50,6 +50,8 @@ int cxl_memdev_read_label(struct cxl_memdev *memdev, void *buf, size_t length,
size_t offset);
int cxl_memdev_write_label(struct cxl_memdev *memdev, void *buf, size_t length,
size_t offset);
+int cxl_memdev_set_partition_info(struct cxl_memdev *memdev,
+ unsigned long long volatile_capacity, int flags);
#define cxl_memdev_foreach(ctx, memdev) \
for (memdev = cxl_memdev_get_first(ctx); \
@@ -117,6 +119,8 @@ unsigned long long cxl_cmd_get_partition_info_get_active_volatile_cap(struct cxl
unsigned long long cxl_cmd_get_partition_info_get_active_persistent_cap(struct cxl_cmd *cmd);
unsigned long long cxl_cmd_get_partition_info_get_next_volatile_cap(struct cxl_cmd *cmd);
unsigned long long cxl_cmd_get_partition_info_get_next_persistent_cap(struct cxl_cmd *cmd);
+struct cxl_cmd *cxl_cmd_new_set_partition_info(struct cxl_memdev *memdev,
+ unsigned long long volatile_capacity, int flags);
#ifdef __cplusplus
} /* extern "C" */
diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
index 85a6c0e..877a783 100644
--- a/cxl/lib/libcxl.c
+++ b/cxl/lib/libcxl.c
@@ -1227,6 +1227,21 @@ cxl_cmd_get_partition_info_get_next_persistent_cap(struct cxl_cmd *cmd)
cmd_partition_get_capacity_field(cmd, next_persistent_cap);
}
+CXL_EXPORT struct cxl_cmd *cxl_cmd_new_set_partition_info(struct cxl_memdev *memdev,
+ unsigned long long volatile_capacity, int flags)
+{
+ struct cxl_cmd_set_partition_info *set_partition;
+ struct cxl_cmd *cmd;
+
+ cmd = cxl_cmd_new_generic(memdev,
+ CXL_MEM_COMMAND_ID_SET_PARTITION_INFO);
+
+ set_partition = (struct cxl_cmd_set_partition_info *)cmd->send_cmd->in.payload;
+ set_partition->volatile_capacity = cpu_to_le64(volatile_capacity);
+ set_partition->flags = flags;
+ return cmd;
+}
+
CXL_EXPORT int cxl_cmd_submit(struct cxl_cmd *cmd)
{
struct cxl_memdev *memdev = cmd->memdev;
@@ -1425,3 +1440,33 @@ CXL_EXPORT int cxl_memdev_read_label(struct cxl_memdev *memdev, void *buf,
{
return lsa_op(memdev, LSA_OP_GET, buf, length, offset);
}
+
+CXL_EXPORT int cxl_memdev_set_partition_info(struct cxl_memdev *memdev,
+ unsigned long long volatile_capacity, int flags)
+{
+ struct cxl_ctx *ctx = cxl_memdev_get_ctx(memdev);
+ struct cxl_cmd *cmd;
+ int rc;
+
+ dbg(ctx, "%s: enter cap: %llx, flags %d\n", __func__,
+ volatile_capacity, flags);
+
+ cmd = cxl_cmd_new_set_partition_info(memdev,
+ volatile_capacity / CXL_CAPACITY_MULTIPLIER, flags);
+ if (!cmd)
+ return -ENXIO;
+
+ rc = cxl_cmd_submit(cmd);
+ if (rc < 0) {
+ err(ctx, "cmd submission failed: %s\n", strerror(-rc));
+ goto err;
+ }
+ rc = cxl_cmd_get_mbox_status(cmd);
+ if (rc != 0) {
+ err(ctx, "%s: mbox status: %d\n", __func__, rc);
+ rc = -ENXIO;
+ }
+err:
+ cxl_cmd_unref(cmd);
+ return rc;
+}
diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
index bed6427..5d02c45 100644
--- a/cxl/lib/libcxl.sym
+++ b/cxl/lib/libcxl.sym
@@ -78,6 +78,9 @@ global:
cxl_cmd_get_partition_info_get_active_persistent_cap;
cxl_cmd_get_partition_info_get_next_volatile_cap;
cxl_cmd_get_partition_info_get_next_persistent_cap;
+ cxl_cmd_new_set_partition_info;
+ cxl_memdev_set_partition_info;
+
local:
*;
};
--
2.31.1
next prev parent reply other threads:[~2022-01-03 20:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 20:16 [ndctl PATCH 0/7] Add partitioning support for CXL memdevs alison.schofield
2022-01-03 20:16 ` [ndctl PATCH 1/7] libcxl: add GET_PARTITION_INFO mailbox command and accessors alison.schofield
2022-01-06 20:19 ` Ira Weiny
2022-01-06 21:21 ` Dan Williams
2022-01-06 21:30 ` Ira Weiny
2022-01-06 21:57 ` Verma, Vishal L
2022-01-07 20:27 ` Alison Schofield
2022-01-07 19:56 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 2/7] libcxl: add accessors for capacity fields of the IDENTIFY command alison.schofield
2022-01-06 20:36 ` Ira Weiny
2022-01-07 20:25 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 3/7] libcxl: apply CXL_CAPACITY_MULTIPLIER to partition alignment field alison.schofield
2022-01-06 20:40 ` Ira Weiny
2022-01-07 20:01 ` Verma, Vishal L
2022-01-03 20:16 ` [ndctl PATCH 4/7] cxl: add memdev partition information to cxl-list alison.schofield
2022-01-06 20:49 ` Ira Weiny
2022-01-07 20:52 ` Alison Schofield
2022-01-06 21:51 ` Dan Williams
2022-01-07 20:32 ` Alison Schofield
2022-01-03 20:16 ` alison.schofield [this message]
2022-01-06 20:53 ` [ndctl PATCH 5/7] libcxl: add interfaces for SET_PARTITION_INFO mailbox command Ira Weiny
2022-01-08 1:51 ` Alison Schofield
2022-01-08 2:27 ` Dan Williams
2022-01-10 2:13 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 6/7] ndctl, util: use 'unsigned long long' type in OPT_U64 define alison.schofield
2022-01-06 20:54 ` Ira Weiny
2022-01-07 20:59 ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 7/7] cxl: add command set-partition-info alison.schofield
2022-01-06 21:05 ` Ira Weiny
2022-01-07 22:51 ` Alison Schofield
2022-01-06 21:35 ` Dan Williams
2022-01-07 22:46 ` Alison Schofield
2022-01-06 22:19 ` Dan Williams
2022-01-07 22:45 ` Alison Schofield
2022-01-10 21:37 ` Alison Schofield
2022-01-06 20:32 ` [ndctl PATCH 0/7] Add partitioning support for CXL memdevs Ira Weiny
2022-01-07 19:44 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa45e95e5d28981b4ec41db65aab82c103bff0c3.1641233076.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox