Re: [PATCH v8 00/11] cxl: Delay HB port and switch dport probing until endpoint dev probe

[Robert Richter <rrichter@amd.com>]

Dave,

On 14.08.25 15:21:40, Dave Jiang wrote:
> v8:
> - A bit of changes from Dan and Robert's comments. Main change is moving the port MMIO
>   register probing to after the first dport shows up. This resulted with decoder allocation
>   happens after the register probe.
> - See specific commits for more detailed changes.

thank you for your rework.

> Dave Jiang (11):
>   cxl: Add helper to detect top of CXL device topology
>   cxl: Add helper to reap dport
>   cxl: Add a cached copy of target_map to cxl_decoder
>   cxl: Move port register setup to first dport appear
>   cxl: Defer dport allocation for switch ports
>   cxl/test: Add cxl_test support for cxl_port_get_possible_dports()
>   cxl/test: Add mock version of devm_cxl_add_dport_by_dev()
>   cxl/test: Add support to cxl_test for decoder enumeration mock
>     functions
>   cxl/test: Setup target_map for cxl_test decoder initialization
>   cxl: Change sslbis handler to only handle single dport
>   tools/testing/cxl: Add decoder save/restore support

I have tested the whole series and it also solves the non-unique port
id errors for offline dports we see like:

 cxl_port port2: unable to add dport247-0000:00:01.3 non-unique port id (0000:00:01.1)

For the whole series you can add:

Tested-by: Robert Richter <rrichter@amd.com>

Thanks,

-Robert

> 
>  drivers/cxl/acpi.c                   |   7 +-
>  drivers/cxl/core/cdat.c              |  25 +-
>  drivers/cxl/core/core.h              |   2 +
>  drivers/cxl/core/hdm.c               |  51 ++--
>  drivers/cxl/core/pci.c               |  82 ++++++
>  drivers/cxl/core/port.c              | 358 ++++++++++++++++++------
>  drivers/cxl/core/region.c            |   4 +-
>  drivers/cxl/cxl.h                    |  44 ++-
>  drivers/cxl/port.c                   |  29 +-
>  tools/testing/cxl/Kbuild             |   5 +-
>  tools/testing/cxl/cxl_core_exports.c |  42 +++
>  tools/testing/cxl/exports.h          |  21 ++
>  tools/testing/cxl/test/cxl.c         | 399 ++++++++++++++++++++++++++-
>  tools/testing/cxl/test/mock.c        |  70 ++++-
>  tools/testing/cxl/test/mock.h        |   3 +
>  15 files changed, 963 insertions(+), 179 deletions(-)
>  create mode 100644 tools/testing/cxl/exports.h
> 
> 
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> -- 
> 2.50.1
>