From: alison.schofield@intel.com
To: Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Dave Jiang <dave.jiang@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>, linux-cxl@vger.kernel.org
Subject: [PATCH 0/5] cxl: CXL Inject & Clear Poison
Date: Tue, 29 Nov 2022 20:34:32 -0800 [thread overview]
Message-ID: <cover.1669781852.git.alison.schofield@intel.com> (raw)
From: Alison Schofield <alison.schofield@intel.com>
Introducing Inject and Clear Poison support for CXL Devices.
These are optional commands, meaning not all CXL devices must support
them. The sysfs attributes, inject_poison and clear_poison, are only
visible for devices reporting support of the capability.
AFAICS the spec does not say support has to come in pairs. A device
could support Inject and not Clear, or the reverse.
Patches 1 & 2 are the required driver implementation.
Patches 3 & 4 are required for testing with cxl_test.
Then there's patch 5. I built on top of the Get Poison Patchset[1]
because Get Poison is useful for checking on the success of Inject
and Clear Poison. Patch 5 teaches the mock of Get Poison how to use
the injected poison list.
That could all be flipped. Inject & Clear could merge first, then
Get Poison would have the capabilities of Patch 5 from the onset.
Or, they can all roll together into one happy patchset.
Example:
# cxl list -m mem1 --media-errors -u
Now you see the default mock media-errors:
{
"memdev":"mem1",
"pmem_size":"1024.00 MiB (1073.74 MB)",
"ram_size":"1024.00 MiB (1073.74 MB)",
"serial":"0x1",
"host":"cxl_mem.1",
"media_errors":{
"nr_media_errors":2,
"media_error_records":[
{
"dpa":"0x40000000",
"length":64,
"source":"Internal",
"flags":"",
"overflow_time":0
},
{
"dpa":"0",
"length":64,
"source":"Internal",
"flags":"",
"overflow_time":0
}
]
}
}
# echo 0x41000000 > /sys/bus/cxl/devices/mem1/inject_poison
# echo 0x30000000 > /sys/bus/cxl/devices/mem1/inject_poison
Now you see the injected mock media-errors:
# cxl list -m mem1 --media-errors -u
{
"memdev":"mem1",
"pmem_size":"1024.00 MiB (1073.74 MB)",
"ram_size":"1024.00 MiB (1073.74 MB)",
"serial":"0x1",
"host":"cxl_mem.1",
"media_errors":{
"nr_media_errors":2,
"media_error_records":[
{
"dpa":"0x41000000",
"length":64,
"source":"Injected",
"flags":"",
"overflow_time":0
},
{
"dpa":"0x30000000",
"length":64,
"source":"Injected",
"flags":"",
"overflow_time":0
}
]
}
Alison Schofield (5):
cxl/memdev: Add support for the Inject Poison mailbox command
cxl/memdev: Add support for the Clear Poison mailbox command
tools/testing/cxl: Mock the Inject Poison mailbox command
tools/testing/cxl: Mock the Clear Poison mailbox command
tools/testing/cxl: Use injected poison for Get Poison List
Documentation/ABI/testing/sysfs-bus-cxl | 36 +++++
drivers/cxl/core/memdev.c | 100 ++++++++++++++
drivers/cxl/cxlmem.h | 9 ++
tools/testing/cxl/test/mem.c | 170 +++++++++++++++++++++---
4 files changed, 295 insertions(+), 20 deletions(-)
--
2.37.3
next reply other threads:[~2022-11-30 4:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 4:34 alison.schofield [this message]
2022-11-30 4:34 ` [PATCH 1/5] cxl/memdev: Add support for the Inject Poison mailbox command alison.schofield
2022-11-30 14:31 ` Jonathan Cameron
2022-11-30 14:40 ` Jonathan Cameron
2022-12-01 16:42 ` Dave Jiang
2022-12-08 4:20 ` Alison Schofield
2022-12-01 17:26 ` Dave Jiang
2022-12-08 4:17 ` Alison Schofield
2022-12-04 22:04 ` Dan Williams
2022-12-08 4:16 ` Alison Schofield
2022-11-30 4:34 ` [PATCH 2/5] cxl/memdev: Add support for the Clear " alison.schofield
2022-11-30 14:43 ` Jonathan Cameron
2022-12-01 20:14 ` Alison Schofield
2022-12-01 17:54 ` Dave Jiang
2022-12-01 20:09 ` Alison Schofield
2022-11-30 4:34 ` [PATCH 3/5] tools/testing/cxl: Mock the Inject " alison.schofield
2022-11-30 14:58 ` Jonathan Cameron
2022-12-08 4:47 ` Alison Schofield
2022-12-08 14:53 ` Jonathan Cameron
2022-11-30 4:34 ` [PATCH 4/5] tools/testing/cxl: Mock the Clear " alison.schofield
2022-11-30 15:01 ` Jonathan Cameron
2022-11-30 4:34 ` [PATCH 5/5] tools/testing/cxl: Use injected poison for Get Poison List alison.schofield
2022-11-30 15:15 ` Jonathan Cameron
2022-12-08 4:30 ` Alison Schofield
2022-12-08 14:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1669781852.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox