From: alison.schofield@intel.com
To: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Cc: Alison Schofield <alison.schofield@intel.com>
Subject: [ndctl PATCH v13 3/8] util/trace: pass an event_ctx to its own parse_event method
Date: Fri, 5 Jul 2024 23:24:49 -0700 [thread overview]
Message-ID: <da9be6ff7edcaef18470cc1579343fc08bc1dc1e.1720241079.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1720241079.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
Tidy-up the calling convention used in trace event parsing by
passing the entire event_ctx to its parse_event method. This
makes it explicit that a parse_event operates on an event_ctx
object and it allows the parse_event function to access any
members of the event_ctx structure.
This is in preparation for adding a private parser requiring more
context for cxl_poison events.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
util/event_trace.c | 9 ++++-----
util/event_trace.h | 2 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/util/event_trace.c b/util/event_trace.c
index 57318e2adace..1f5c180a030b 100644
--- a/util/event_trace.c
+++ b/util/event_trace.c
@@ -60,7 +60,7 @@ static struct json_object *num_to_json(void *num, int elem_size, unsigned long f
}
static int event_to_json(struct tep_event *event, struct tep_record *record,
- struct list_head *jlist_head)
+ struct event_ctx *ctx)
{
struct json_object *jevent, *jobj, *jarray;
struct tep_format_field **fields;
@@ -190,7 +190,7 @@ static int event_to_json(struct tep_event *event, struct tep_record *record,
}
}
- list_add_tail(jlist_head, &jnode->list);
+ list_add_tail(&ctx->jlist_head, &jnode->list);
return 0;
err_jevent:
@@ -220,10 +220,9 @@ static int event_parse(struct tep_event *event, struct tep_record *record,
}
if (event_ctx->parse_event)
- return event_ctx->parse_event(event, record,
- &event_ctx->jlist_head);
+ return event_ctx->parse_event(event, record, event_ctx);
- return event_to_json(event, record, &event_ctx->jlist_head);
+ return event_to_json(event, record, event_ctx);
}
int trace_event_parse(struct tracefs_instance *inst, struct event_ctx *ectx)
diff --git a/util/event_trace.h b/util/event_trace.h
index 6586e1dc254d..9c53eba7533f 100644
--- a/util/event_trace.h
+++ b/util/event_trace.h
@@ -17,7 +17,7 @@ struct event_ctx {
const char *event_name; /* optional */
int event_pid; /* optional */
int (*parse_event)(struct tep_event *event, struct tep_record *record,
- struct list_head *jlist_head); /* optional */
+ struct event_ctx *ctx);
};
int trace_event_parse(struct tracefs_instance *inst, struct event_ctx *ectx);
--
2.37.3
next prev parent reply other threads:[~2024-07-06 6:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 6:24 [ndctl PATCH v13 0/8] Support poison list retrieval alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 1/8] util/trace: move trace helpers from ndctl/cxl/ to ndctl/util/ alison.schofield
2024-07-24 20:50 ` Dave Jiang
2024-07-06 6:24 ` [ndctl PATCH v13 2/8] util/trace: add an optional pid check to event parsing alison.schofield
2024-07-06 6:24 ` alison.schofield [this message]
2024-07-24 20:55 ` [ndctl PATCH v13 3/8] util/trace: pass an event_ctx to its own parse_event method Dave Jiang
2024-07-06 6:24 ` [ndctl PATCH v13 4/8] util/trace: add helpers to retrieve tep fields by type alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 5/8] libcxl: add interfaces for GET_POISON_LIST mailbox commands alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 6/8] cxl/list: collect and parse media_error records alison.schofield
2024-07-08 2:07 ` Xingtao Yao (Fujitsu)
2024-07-08 20:54 ` Alison Schofield
2024-07-06 6:24 ` [ndctl PATCH v13 7/8] cxl/list: add --media-errors option to cxl list alison.schofield
2024-07-08 2:26 ` Xingtao Yao (Fujitsu)
2024-07-08 20:56 ` Alison Schofield
2024-07-06 6:24 ` [ndctl PATCH v13 8/8] cxl/test: add cxl-poison.sh unit test alison.schofield
2024-07-08 2:10 ` Xingtao Yao (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da9be6ff7edcaef18470cc1579343fc08bc1dc1e.1720241079.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox