From: Alison Schofield <alison.schofield@intel.com>
To: "Xingtao Yao (Fujitsu)" <yaoxt.fnst@fujitsu.com>
Cc: "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [ndctl PATCH v13 6/8] cxl/list: collect and parse media_error records
Date: Mon, 8 Jul 2024 13:54:24 -0700 [thread overview]
Message-ID: <ZoxSAC5XV9kTNwy+@aschofie-mobl2> (raw)
In-Reply-To: <OSZPR01MB64538FDD3908A8A2CBBEDD938DDA2@OSZPR01MB6453.jpnprd01.prod.outlook.com>
On Mon, Jul 08, 2024 at 02:07:41AM +0000, Xingtao Yao (Fujitsu) wrote:
> > +/* CXL Spec 3.1 Table 8-140 Media Error Record */
> > +#define CXL_POISON_SOURCE_MAX 7
> > +static const char * const poison_source[] = { "Unknown", "External", "Internal",
> > + "Injected", "Reserved", "Reserved",
> > + "Reserved", "Vendor" };
> it might be better to use "Vendor Specific" instead of "Vendor".
I see that "Vendor Specific" would be an exact match with the spec, so yes,
I'll change that. Thanks for pointing out.
--Alison
>
> Reviewed-by: Xingtao Yao <yaoxt.fnst@fujitsu.com>
next prev parent reply other threads:[~2024-07-08 20:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 6:24 [ndctl PATCH v13 0/8] Support poison list retrieval alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 1/8] util/trace: move trace helpers from ndctl/cxl/ to ndctl/util/ alison.schofield
2024-07-24 20:50 ` Dave Jiang
2024-07-06 6:24 ` [ndctl PATCH v13 2/8] util/trace: add an optional pid check to event parsing alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 3/8] util/trace: pass an event_ctx to its own parse_event method alison.schofield
2024-07-24 20:55 ` Dave Jiang
2024-07-06 6:24 ` [ndctl PATCH v13 4/8] util/trace: add helpers to retrieve tep fields by type alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 5/8] libcxl: add interfaces for GET_POISON_LIST mailbox commands alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 6/8] cxl/list: collect and parse media_error records alison.schofield
2024-07-08 2:07 ` Xingtao Yao (Fujitsu)
2024-07-08 20:54 ` Alison Schofield [this message]
2024-07-06 6:24 ` [ndctl PATCH v13 7/8] cxl/list: add --media-errors option to cxl list alison.schofield
2024-07-08 2:26 ` Xingtao Yao (Fujitsu)
2024-07-08 20:56 ` Alison Schofield
2024-07-06 6:24 ` [ndctl PATCH v13 8/8] cxl/test: add cxl-poison.sh unit test alison.schofield
2024-07-08 2:10 ` Xingtao Yao (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoxSAC5XV9kTNwy+@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=yaoxt.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox