From: alison.schofield@intel.com
To: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Cc: Alison Schofield <alison.schofield@intel.com>,
Dave Jiang <dave.jiang@intel.com>
Subject: [ndctl PATCH v13 5/8] libcxl: add interfaces for GET_POISON_LIST mailbox commands
Date: Fri, 5 Jul 2024 23:24:51 -0700 [thread overview]
Message-ID: <ef5503682f5042e68f153824634a751b41d1342a.1720241079.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1720241079.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
CXL devices maintain a list of locations that are poisoned or result
in poison if the addresses are accessed by the host.
Per the spec (CXL 3.1 8.2.9.9.4.1), the device returns the Poison
List as a set of Media Error Records that include the source of the
error, the starting device physical address and length.
Trigger the retrieval of the poison list by writing to the memory
device sysfs attribute: trigger_poison_list. The CXL driver only
offers triggering per memdev, so the trigger by region interface
offered here is a convenience API that triggers a poison list
retrieval for each memdev contributing to a region.
int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev);
int cxl_region_trigger_poison_list(struct cxl_region *region);
The resulting poison records are logged as kernel trace events
named 'cxl_poison'.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
---
cxl/lib/libcxl.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++
cxl/lib/libcxl.sym | 6 ++++++
cxl/libcxl.h | 2 ++
3 files changed, 61 insertions(+)
diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
index 91eedd1c4688..63aa4ef3acdc 100644
--- a/cxl/lib/libcxl.c
+++ b/cxl/lib/libcxl.c
@@ -1762,6 +1762,59 @@ CXL_EXPORT int cxl_memdev_disable_invalidate(struct cxl_memdev *memdev)
return 0;
}
+CXL_EXPORT int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev)
+{
+ struct cxl_ctx *ctx = cxl_memdev_get_ctx(memdev);
+ char *path = memdev->dev_buf;
+ int len = memdev->buf_len, rc;
+
+ if (snprintf(path, len, "%s/trigger_poison_list",
+ memdev->dev_path) >= len) {
+ err(ctx, "%s: buffer too small\n",
+ cxl_memdev_get_devname(memdev));
+ return -ENXIO;
+ }
+
+ if (access(path, F_OK) != 0) {
+ err(ctx, "%s: trigger_poison_list unsupported by device\n",
+ cxl_memdev_get_devname(memdev));
+ return -ENXIO;
+ }
+
+ rc = sysfs_write_attr(ctx, path, "1\n");
+ if (rc < 0) {
+ err(ctx, "%s: Failed trigger_poison_list\n",
+ cxl_memdev_get_devname(memdev));
+ return rc;
+ }
+ return 0;
+}
+
+CXL_EXPORT int cxl_region_trigger_poison_list(struct cxl_region *region)
+{
+ struct cxl_memdev_mapping *mapping;
+ int rc;
+
+ cxl_mapping_foreach(region, mapping) {
+ struct cxl_decoder *decoder;
+ struct cxl_memdev *memdev;
+
+ decoder = cxl_mapping_get_decoder(mapping);
+ if (!decoder)
+ continue;
+
+ memdev = cxl_decoder_get_memdev(decoder);
+ if (!memdev)
+ continue;
+
+ rc = cxl_memdev_trigger_poison_list(memdev);
+ if (rc)
+ return rc;
+ }
+
+ return 0;
+}
+
CXL_EXPORT int cxl_memdev_enable(struct cxl_memdev *memdev)
{
struct cxl_ctx *ctx = cxl_memdev_get_ctx(memdev);
diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
index 304d7fa735d4..0c155a40ad47 100644
--- a/cxl/lib/libcxl.sym
+++ b/cxl/lib/libcxl.sym
@@ -282,3 +282,9 @@ global:
cxl_region_qos_class_mismatch;
cxl_port_decoders_committed;
} LIBCXL_6;
+
+LIBECXL_8 {
+global:
+ cxl_memdev_trigger_poison_list;
+ cxl_region_trigger_poison_list;
+} LIBCXL_7;
diff --git a/cxl/libcxl.h b/cxl/libcxl.h
index fc6dd0085440..0a5fd0e13cc2 100644
--- a/cxl/libcxl.h
+++ b/cxl/libcxl.h
@@ -468,6 +468,8 @@ enum cxl_setpartition_mode {
int cxl_cmd_partition_set_mode(struct cxl_cmd *cmd,
enum cxl_setpartition_mode mode);
+int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev);
+int cxl_region_trigger_poison_list(struct cxl_region *region);
int cxl_cmd_alert_config_set_life_used_prog_warn_threshold(struct cxl_cmd *cmd,
int threshold);
--
2.37.3
next prev parent reply other threads:[~2024-07-06 6:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 6:24 [ndctl PATCH v13 0/8] Support poison list retrieval alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 1/8] util/trace: move trace helpers from ndctl/cxl/ to ndctl/util/ alison.schofield
2024-07-24 20:50 ` Dave Jiang
2024-07-06 6:24 ` [ndctl PATCH v13 2/8] util/trace: add an optional pid check to event parsing alison.schofield
2024-07-06 6:24 ` [ndctl PATCH v13 3/8] util/trace: pass an event_ctx to its own parse_event method alison.schofield
2024-07-24 20:55 ` Dave Jiang
2024-07-06 6:24 ` [ndctl PATCH v13 4/8] util/trace: add helpers to retrieve tep fields by type alison.schofield
2024-07-06 6:24 ` alison.schofield [this message]
2024-07-06 6:24 ` [ndctl PATCH v13 6/8] cxl/list: collect and parse media_error records alison.schofield
2024-07-08 2:07 ` Xingtao Yao (Fujitsu)
2024-07-08 20:54 ` Alison Schofield
2024-07-06 6:24 ` [ndctl PATCH v13 7/8] cxl/list: add --media-errors option to cxl list alison.schofield
2024-07-08 2:26 ` Xingtao Yao (Fujitsu)
2024-07-08 20:56 ` Alison Schofield
2024-07-06 6:24 ` [ndctl PATCH v13 8/8] cxl/test: add cxl-poison.sh unit test alison.schofield
2024-07-08 2:10 ` Xingtao Yao (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef5503682f5042e68f153824634a751b41d1342a.1720241079.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox