Re: [PATCH 1/1] arm64: dts: imx8mp: Update pin function file according to Rev.D RM

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello,

On 11/24/25 4:08 PM, Aisheng Dong wrote:
>> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> Sent: Monday, November 24, 2025 9:54 PM
>>> Could you help elaborate a bit more why need keep the old defines as I
>>> saw the previous update patch also didn't keep them?
>>
>> Which previous update patch do you refer to?
>>
> 
> I mean this patch:
> 
> commit bcf7206fe9c35e048e1dc90cf62216b0f5eaf091
> Author: Anson Huang <Anson.Huang@nxp.com>
> Date:   Fri Aug 14 17:27:19 2020 +0800
> 
>     arm64: dts: imx8mp: Update pinfunc header file

2020 was the same year the file was added, so any fallout it could have
caused back then would have been minimal anyway.


>> Generally, If the defines are wrong or misleading, I am all for renaming them.
>>
>> In this case, NXP changed their mind and renamed the function in an
>> (unreleased)) reference manual.
> 
> This is not accurate. The RM with updated names has been released.

Thanks for clarifying. I had meant to add a question mark :)

>> The tradeoff here is between:
>>
>> - amount of confusion avoided when we rename USB_OTG to USB
>> - amount of overhead introduced to adapt device trees
>>
>> I think the benefit of the rename is marginal at best and not worth the
>> unnecessary breakage it would impose on countless downstream users with
>> out-of-tree board device trees.
> 
> I agree the benefit of USB renaming may be arguable.
> But how about the remain changes (drop invalid defines and adding new ones)?
> Are they still need to be fixed?

The other changes are ok, although it would be good to add a short info
to the commit message especially about the removed macros if you have
any extra information why these pad functions are no longer applicable.

Thanks,
Ahmad



> 
> Regards
> Aisheng
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |