Re: [PATCH 1/1] arm64: dts: imx8mp: Update pin function file according to Rev.D RM

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 11/24/25 2:39 PM, Aisheng Dong wrote:
>> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> Sent: Monday, November 24, 2025 8:07 PM
>> Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: Update pin function file
>> according to Rev.D RM
>>
>> Hi,
>>
>> On 11/24/25 10:54 AM, Dong Aisheng wrote:
>>> From: Anson Huang <Anson.Huang@nxp.com>
>>>
>>> Update i.MX8MP imx8mp-pinfunc.h file according to reference manual
>> Rev.D.
>>>
>>> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>>> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
>>
>> At the very least, we should keep around the old defines.
>>
> 
> Could you help elaborate a bit more why need keep the old defines as I saw the previous
> update patch also didn't keep them?

Which previous update patch do you refer to?

Generally, If the defines are wrong or misleading, I am all for renaming
them.

In this case, NXP changed their mind and renamed the function in an
(unreleased)) reference manual.

The tradeoff here is between:

- amount of confusion avoided when we rename USB_OTG to USB
- amount of overhead introduced to adapt device trees

I think the benefit of the rename is marginal at best and not worth the
unnecessary breakage it would impose on countless downstream users with
out-of-tree board device trees.

Cheers,
Ahmad

>> I don't think though that aligning with slightly different naming in a newer
>> reference manual is worth the churn.
> 
> Besides the renaming, also dropped some invalid defines and added new ones.
> 
> Regards
> Aisheng
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |