[PATCH 0/2] power: qcom,rpmpd: Add support for Shikra

[PATCH 0/2] power: qcom,rpmpd: Add support for Shikra

[Rakesh Kota]

Add rpmpd support for shikra Platform including RPM power domains.

Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
---
Rakesh Kota (2):
      dt-bindings: power: qcom,rpmpd: document the Shikra RPM Power Domains
      soc: qcom: rpmpd: Add Shikra RPM Power Domains

 Documentation/devicetree/bindings/power/qcom,rpmpd.yaml |  1 +
 drivers/pmdomain/qcom/rpmpd.c                           | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)
---
base-commit: 0787c45ea08a13b5482e701fabc741877cf681f6
change-id: 20260429-add_rpmpd_shikra-f57873b2fa7c

Best regards,
-- 
Rakesh Kota <rakesh.kota@oss.qualcomm.com>

[PATCH 1/2] dt-bindings: power: qcom,rpmpd: document the Shikra RPM Power Domains

[Rakesh Kota]

Document the RPM Power Domains on the Shikra Platform.

Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index 0bf1e13a99646c0325b03fc5b3297ebada21cdb6..1abb4b733fe79dfa267e953f48219093ad759330 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -55,6 +55,7 @@ properties:
           - qcom,sdx55-rpmhpd
           - qcom,sdx65-rpmhpd
           - qcom,sdx75-rpmhpd
+          - qcom,shikra-rpmpd
           - qcom,sm4450-rpmhpd
           - qcom,sm6115-rpmpd
           - qcom,sm6125-rpmpd

-- 
2.34.1

[PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains

[Rakesh Kota]

Add RPM Power Domains support for the Shikra platform.

Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
---
 drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
--- a/drivers/pmdomain/qcom/rpmpd.c
+++ b/drivers/pmdomain/qcom/rpmpd.c
@@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
 	.max_state = RPM_SMD_LEVEL_TURBO,
 };
 
+static struct rpmpd *shikra_rpmpds[] = {
+	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
+	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
+	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
+	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
+	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
+	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
+};
+
+static const struct rpmpd_desc shikra_desc = {
+	.rpmpds = shikra_rpmpds,
+	.num_pds = ARRAY_SIZE(shikra_rpmpds),
+	.max_state = RPM_SMD_LEVEL_TURBO_NO_CPR,
+};
+
 static struct rpmpd *sm6115_rpmpds[] = {
 	[SM6115_VDDCX] =	&cx_rwcx0_lvl,
 	[SM6115_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
@@ -949,6 +964,7 @@ static const struct of_device_id rpmpd_match_table[] = {
 	{ .compatible = "qcom,qcs404-rpmpd", .data = &qcs404_desc },
 	{ .compatible = "qcom,qm215-rpmpd", .data = &qm215_desc },
 	{ .compatible = "qcom,sdm660-rpmpd", .data = &sdm660_desc },
+	{ .compatible = "qcom,shikra-rpmpd", .data = &shikra_desc },
 	{ .compatible = "qcom,sm6115-rpmpd", .data = &sm6115_desc },
 	{ .compatible = "qcom,sm6125-rpmpd", .data = &sm6125_desc },
 	{ .compatible = "qcom,sm6375-rpmpd", .data = &sm6375_desc },

-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document the Shikra RPM Power Domains

[Krzysztof Kozlowski]

On Wed, Apr 29, 2026 at 07:39:56PM +0530, Rakesh Kota wrote:
> Document the RPM Power Domains on the Shikra Platform.
> 
> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains

[Konrad Dybcio]

On 4/29/26 4:09 PM, Rakesh Kota wrote:
> Add RPM Power Domains support for the Shikra platform.
> 
> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> ---
>  drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
> index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
> --- a/drivers/pmdomain/qcom/rpmpd.c
> +++ b/drivers/pmdomain/qcom/rpmpd.c
> @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
>  	.max_state = RPM_SMD_LEVEL_TURBO,
>  };
>  
> +static struct rpmpd *shikra_rpmpds[] = {
> +	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
> +	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
> +	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
> +	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
> +	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
> +	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
> +};

This is identical to sm6125_rpmpds. If you're sure the list is correct
and complete (no LPI domains etc.), you can drop this patch, and proceed
with just this change:

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index 0bf1e13a9964..e7d9e8e65641 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -73,6 +73,10 @@ properties:
           - enum:
               - qcom,msm8937-rpmpd
           - const: qcom,msm8917-rpmpd
+      - items:
+          - enum:
+              - qcom,shikra-rpmpd
+          - const: qcom,sm6125-rpmpd
 
   '#power-domain-cells':
     const: 1


Konrad

Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains

[Rakesh Kota]

On Tue, May 12, 2026 at 02:16:07PM +0200, Konrad Dybcio wrote:
> On 4/29/26 4:09 PM, Rakesh Kota wrote:
> > Add RPM Power Domains support for the Shikra platform.
> > 
> > Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> > ---
> >  drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
> > index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
> > --- a/drivers/pmdomain/qcom/rpmpd.c
> > +++ b/drivers/pmdomain/qcom/rpmpd.c
> > @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
> >  	.max_state = RPM_SMD_LEVEL_TURBO,
> >  };
> >  
> > +static struct rpmpd *shikra_rpmpds[] = {
> > +	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
> > +	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
> > +	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
> > +	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
> > +	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
> > +	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
> > +};
> 
> This is identical to sm6125_rpmpds. If you're sure the list is correct
> and complete (no LPI domains etc.), you can drop this patch, and proceed
> with just this change:
>
There is one difference — the max_state for Shikra is
RPM_SMD_LEVEL_TURBO_NO_CPR, whereas sm6125 uses RPM_SMD_LEVEL_BINNING. 

regards
Rakesh Kota

> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> index 0bf1e13a9964..e7d9e8e65641 100644
> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -73,6 +73,10 @@ properties:
>            - enum:
>                - qcom,msm8937-rpmpd
>            - const: qcom,msm8917-rpmpd
> +      - items:
> +          - enum:
> +              - qcom,shikra-rpmpd
> +          - const: qcom,sm6125-rpmpd
>  
>    '#power-domain-cells':
>      const: 1
> 
> 
> Konrad

Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains

[Konrad Dybcio]

On 5/14/26 10:45 AM, Rakesh Kota wrote:
> On Tue, May 12, 2026 at 02:16:07PM +0200, Konrad Dybcio wrote:
>> On 4/29/26 4:09 PM, Rakesh Kota wrote:
>>> Add RPM Power Domains support for the Shikra platform.
>>>
>>> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
>>> ---
>>>  drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
>>>  1 file changed, 16 insertions(+)
>>>
>>> diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
>>> index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
>>> --- a/drivers/pmdomain/qcom/rpmpd.c
>>> +++ b/drivers/pmdomain/qcom/rpmpd.c
>>> @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
>>>  	.max_state = RPM_SMD_LEVEL_TURBO,
>>>  };
>>>  
>>> +static struct rpmpd *shikra_rpmpds[] = {
>>> +	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
>>> +	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
>>> +	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
>>> +	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
>>> +	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
>>> +	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
>>> +};
>>
>> This is identical to sm6125_rpmpds. If you're sure the list is correct
>> and complete (no LPI domains etc.), you can drop this patch, and proceed
>> with just this change:
>>
> There is one difference — the max_state for Shikra is
> RPM_SMD_LEVEL_TURBO_NO_CPR, whereas sm6125 uses RPM_SMD_LEVEL_BINNING. 

You're right

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains

[Dmitry Baryshkov]

On Thu, May 14, 2026 at 02:15:12PM +0530, Rakesh Kota wrote:
> On Tue, May 12, 2026 at 02:16:07PM +0200, Konrad Dybcio wrote:
> > On 4/29/26 4:09 PM, Rakesh Kota wrote:
> > > Add RPM Power Domains support for the Shikra platform.
> > > 
> > > Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> > > ---
> > >  drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
> > >  1 file changed, 16 insertions(+)
> > > 
> > > diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
> > > index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
> > > --- a/drivers/pmdomain/qcom/rpmpd.c
> > > +++ b/drivers/pmdomain/qcom/rpmpd.c
> > > @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
> > >  	.max_state = RPM_SMD_LEVEL_TURBO,
> > >  };
> > >  
> > > +static struct rpmpd *shikra_rpmpds[] = {
> > > +	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
> > > +	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
> > > +	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
> > > +	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
> > > +	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
> > > +	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
> > > +};
> > 
> > This is identical to sm6125_rpmpds. If you're sure the list is correct
> > and complete (no LPI domains etc.), you can drop this patch, and proceed
> > with just this change:
> >
> There is one difference — the max_state for Shikra is
> RPM_SMD_LEVEL_TURBO_NO_CPR, whereas sm6125 uses RPM_SMD_LEVEL_BINNING. 

It's handled in the DT. As such, programming model and the domain list
looks the same and compatible.

> 
> regards
> Rakesh Kota
> 
> > diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> > index 0bf1e13a9964..e7d9e8e65641 100644
> > --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> > +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> > @@ -73,6 +73,10 @@ properties:
> >            - enum:
> >                - qcom,msm8937-rpmpd
> >            - const: qcom,msm8917-rpmpd
> > +      - items:
> > +          - enum:
> > +              - qcom,shikra-rpmpd
> > +          - const: qcom,sm6125-rpmpd
> >  
> >    '#power-domain-cells':
> >      const: 1
> > 
> > 
> > Konrad

-- 
With best wishes
Dmitry

Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains

[Konrad Dybcio]

On 5/14/26 11:16 AM, Dmitry Baryshkov wrote:
> On Thu, May 14, 2026 at 02:15:12PM +0530, Rakesh Kota wrote:
>> On Tue, May 12, 2026 at 02:16:07PM +0200, Konrad Dybcio wrote:
>>> On 4/29/26 4:09 PM, Rakesh Kota wrote:
>>>> Add RPM Power Domains support for the Shikra platform.
>>>>
>>>> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
>>>> ---
>>>>  drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
>>>>  1 file changed, 16 insertions(+)
>>>>
>>>> diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
>>>> index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
>>>> --- a/drivers/pmdomain/qcom/rpmpd.c
>>>> +++ b/drivers/pmdomain/qcom/rpmpd.c
>>>> @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
>>>>  	.max_state = RPM_SMD_LEVEL_TURBO,
>>>>  };
>>>>  
>>>> +static struct rpmpd *shikra_rpmpds[] = {
>>>> +	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
>>>> +	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
>>>> +	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
>>>> +	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
>>>> +	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
>>>> +	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
>>>> +};
>>>
>>> This is identical to sm6125_rpmpds. If you're sure the list is correct
>>> and complete (no LPI domains etc.), you can drop this patch, and proceed
>>> with just this change:
>>>
>> There is one difference — the max_state for Shikra is
>> RPM_SMD_LEVEL_TURBO_NO_CPR, whereas sm6125 uses RPM_SMD_LEVEL_BINNING. 
> 
> It's handled in the DT. As such, programming model and the domain list
> looks the same and compatible.

Yes/no, this is an upper bound

one improvement we could still make to this patch is not to define
shikra_rpmpds[], but refer to the existing sm6125 one

Konrad

Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains

[Dmitry Baryshkov]

On Thu, May 14, 2026 at 11:23:39AM +0200, Konrad Dybcio wrote:
> On 5/14/26 11:16 AM, Dmitry Baryshkov wrote:
> > On Thu, May 14, 2026 at 02:15:12PM +0530, Rakesh Kota wrote:
> >> On Tue, May 12, 2026 at 02:16:07PM +0200, Konrad Dybcio wrote:
> >>> On 4/29/26 4:09 PM, Rakesh Kota wrote:
> >>>> Add RPM Power Domains support for the Shikra platform.
> >>>>
> >>>> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> >>>> ---
> >>>>  drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
> >>>>  1 file changed, 16 insertions(+)
> >>>>
> >>>> diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
> >>>> index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
> >>>> --- a/drivers/pmdomain/qcom/rpmpd.c
> >>>> +++ b/drivers/pmdomain/qcom/rpmpd.c
> >>>> @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
> >>>>  	.max_state = RPM_SMD_LEVEL_TURBO,
> >>>>  };
> >>>>  
> >>>> +static struct rpmpd *shikra_rpmpds[] = {
> >>>> +	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
> >>>> +	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
> >>>> +	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
> >>>> +	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
> >>>> +	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
> >>>> +	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
> >>>> +};
> >>>
> >>> This is identical to sm6125_rpmpds. If you're sure the list is correct
> >>> and complete (no LPI domains etc.), you can drop this patch, and proceed
> >>> with just this change:
> >>>
> >> There is one difference — the max_state for Shikra is
> >> RPM_SMD_LEVEL_TURBO_NO_CPR, whereas sm6125 uses RPM_SMD_LEVEL_BINNING. 
> > 
> > It's handled in the DT. As such, programming model and the domain list
> > looks the same and compatible.
> 
> Yes/no, this is an upper bound
> 
> one improvement we could still make to this patch is not to define
> shikra_rpmpds[], but refer to the existing sm6125 one

SGTM

-- 
With best wishes
Dmitry