Re: [PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART

Re: [PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART

[liu.qingtao2]

Thanks for your kindly review. Sorry for the delay.

> On 13/02/2026 10:33, LiuQingtao wrote:
> > From: Wenhong Liu <liu.wenhong35@zte.com.cn>
> >
> > Add documentation for LRW UART devicetree bindings.
> >
> > Signed-off-by: Wenhong Liu <liu.wenhong35@zte.com.cn>
> > Signed-off-by: Qingtao Liu <liu.qingtao2@zte.com.cn>
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
>
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Thanks for the notice. I will change the subject to "Add devicetree binding for ZTE LRX UART controller"
in the v2 patch series.


> > ---
> >  .../bindings/serial/lrw,lrw-uart.yaml         | 49 +++++++++++++++++++
> >  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> >  MAINTAINERS                                   |  7 +++
> >  3 files changed, 58 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml b/Documentation/devicetree/bindings/> serial/lrw,lrw-uart.yaml
> > new file mode 100644
> > index 000000000000..a2d41c278c4f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/serial/lrw-uart.yaml#
>
> Never tested, NAK. There are several other issues here, but I am not
> going through rest of review if you did not bother to even build test
> it. Please open any other recent binding and apply same style here
> (filename, descriptions etc), so you won't be repeating SAME mistakes.
>
>

Sorry, i tested on an older version kernel.
No errors or warnings ever showed up running the command
"make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/zte,lrx-uart.yaml".

Log from v2 patch:

$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/zte,lrx-uart.yaml
 SCHEMA  Documentation/devicetree/bindings/processed-schema.json
 CHKDT   ./Documentation/devicetree/bindings
 LINT    ./Documentation/devicetree/bindings
 DTEX    Documentation/devicetree/bindings/serial/zte,lrx-uart.example.dts
 DTC [C] Documentation/devicetree/bindings/serial/zte,lrx-uart.example.dtb

> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: LRW serial UART
> > +
> > +maintainers:
> > +  - Wenhong Liu <liu.wenhong35@zte.com.cn>
> > +  - Qingtao Liu <liu.qingtao2@zte.com.cn>
> > +
> > +description: |
> > +  Should be something similar to "lrw,<chip>-uart"
> > +  for the UART as integrated on a particular chip, It supports
> > +  multiple CPU architectures, currently including e.g. RISC-V and ARM.
> > +
> > +properties:
> > +  compatible:
> > +    const: lrw,lrw-uart
>
> No way lrw is a chip if this is a company.

Sorry for the name problem. lrw is a subsidiary of ZTE.
We will use ZTE as company name and lrx as chip name in the v2 patches.
lrx is a chip that will be comming up soon.

> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - current-speed
> > +  - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    uart0: serial@e0001800 {
> > +      compatible = "lrw,lrw-uart";
> > +      interrupt-parent = <&aplic0>;
> > +      interrupts = <0x12 0x4>;
> > +      reg = <0xe0001800 0x100>;
> > +      clocks = <&bar_clk>;
> > +      current-speed = <115200>;
> > +    };
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/> vendor-prefixes.yaml
> > index ee7fd3cfe203..ec9bf262f466 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -961,6 +961,8 @@ patternProperties:
> >      description: Loongson Technology Corporation Limited
> >    "^loongmasses,.*":
> >      description: Nanjing Loongmasses Ltd.
> > +  "^lrw,.*":
> > +    description: LRW Corp.
>
> What is the website/domain address?
>
>
> Best regards,
> Krzysztof

There won't be such problem since we use ZTE as company name.
ZTE was described in Documentation/devicetree/bindings/vendor-prefixes.yaml already.

Thanks,
Qingtao Liu

Re: [PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART

[liu.qingtao2]

> On 13/02/2026 10:33, LiuQingtao wrote:
> > From: Wenhong Liu <liu.wenhong35@zte.com.cn>
> >
> > Add documentation for LRW UART devicetree bindings.
> >
> > Signed-off-by: Wenhong Liu <liu.wenhong35@zte.com.cn>
> > Signed-off-by: Qingtao Liu <liu.qingtao2@zte.com.cn>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don&apos;t, instead use mainline) or work on fork of kernel
> (don&apos;t, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won&apos;t be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
>
> Please kindly resend and include all necessary To/Cc entries.
>
>
> Best regards,
> Krzysztof

Much thanks. I got correct lists based on most recent Linux kernel.
I'll resend v2 patches soon.

Re: [PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART

[Krzysztof Kozlowski]

On 13/05/2026 10:43, liu.qingtao2@zte.com.cn wrote:
> Thanks for your kindly review. Sorry for the delay.
> 
>> On 13/02/2026 10:33, LiuQingtao wrote:
>>> From: Wenhong Liu <liu.wenhong35@zte.com.cn>
>>>
>>> Add documentation for LRW UART devicetree bindings.
>>>
>>> Signed-off-by: Wenhong Liu <liu.wenhong35@zte.com.cn>
>>> Signed-off-by: Qingtao Liu <liu.qingtao2@zte.com.cn>
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
>>
>> A nit, subject: drop second/last, redundant "bindings". The
>> "dt-bindings" prefix is already stating that these are bindings.
>> See also:
>> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> Thanks for the notice. I will change the subject to "Add devicetree binding for ZTE LRX UART controller"
> in the v2 patch series.

NAK. Read the comment again. You improved nothing.

> 
> 
>>> ---
>>>  .../bindings/serial/lrw,lrw-uart.yaml         | 49 +++++++++++++++++++
>>>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>>>  MAINTAINERS                                   |  7 +++
>>>  3 files changed, 58 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml b/Documentation/devicetree/bindings/> serial/lrw,lrw-uart.yaml
>>> new file mode 100644
>>> index 000000000000..a2d41c278c4f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
>>> @@ -0,0 +1,49 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/serial/lrw-uart.yaml#
>>
>> Never tested, NAK. There are several other issues here, but I am not
>> going through rest of review if you did not bother to even build test
>> it. Please open any other recent binding and apply same style here
>> (filename, descriptions etc), so you won't be repeating SAME mistakes.
>>
>>
> 
> Sorry, i tested on an older version kernel.
> No errors or warnings ever showed up running the command
> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/zte,lrx-uart.yaml".
> 

Don't work on older kernel. It's not an excuse.

Best regards,
Krzysztof