From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
jishnu.prakash@oss.qualcomm.com,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property
Date: Thu, 2 Jul 2026 13:48:22 +0200 [thread overview]
Message-ID: <08ef6b3e-be83-4516-954d-dbdb68776df2@kernel.org> (raw)
In-Reply-To: <20260702113010.zjrk4kr7fpjp6asj@hu-kotarake-hyd.qualcomm.com>
On 02/07/2026 13:30, Rakesh Kota wrote:
> On Mon, May 25, 2026 at 05:31:39PM +0530, Rakesh Kota wrote:
>> On Fri, May 22, 2026 at 11:24:19AM +0200, Konrad Dybcio wrote:
>>> On 5/21/26 11:58 AM, Krzysztof Kozlowski wrote:
>>>> On 21/05/2026 10:46, Konrad Dybcio wrote:
>>>>> On 5/21/26 9:20 AM, Krzysztof Kozlowski wrote:
>>>>>>> Since firmware does not have a way to dynamically tell if it on a
>>>>>>> debug-board powered device or a DCIN powered device, We are required to
>>>>>>> add this new DT property.
>>>>>>
>>>>>> Neither debug-board powered device nor battery-less will have
>>>>>> monitored-battery, thus again, why lack of that property cannot tell you
>>>>>> what you need?
>>>>>
>>>>> A device with a battery will not have a monitored-battery either
>>>> But why? If for such device property "no battery" is suitable, then for
>>>> me "monitored-battery" is suitable as well. IOW, if you say that having
>>>> a property describing batter is not a accurate hardware property here,
>>>> then neither saying "no battery" is, because no batter is basically some
>>>> sort of battery (just like empty set is still a set, empty array is
>>>> still an array).
>>>
>>> The battmgr service running on one of the remoteprocs already has all
>>> the information about the battery and it also handles all the type-c,
>>> PD and charger configuration, only letting the OS know about the
>>> results.
>>>
>>> Hence, unless there's some other hardware at play (e.g. for custom
>>> 200 W charging), which wasn't fully implemented in the QC firmware,
>>> there is no reason to describe a battery separately, since the OS
>>> can't do anything useful with that information
>>>
>>> In some abstract way, perhaps monitored_battery = <&pmic_glink> could
>>> be thought of as valid (since that's the data source the OS gets to
>>> see)
>>
>> Should we use monitored-battery = <&pmic_glink>; If so, would it be
>> incorrect to mark pmic_glink as simple-battery, as that may cause the
>> schema validation to fail?
>
> Hi @Konrad Dybcio, @Krzysztof Kozlowski ,
>
> Following up on the earlier discussion — is monitored-battery =
> <&pmic_glink>; a valid pattern? And if so, would marking pmic_glink as
> simple-battery cause DT schema validation failures?
No, pmic is not the monitored batter. Node representing real batter
would be, but the main point remains - your firmware abstracts it, so
fix the firmware to provide proper abstraction.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-02 11:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 13:49 [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Rakesh Kota
2026-05-18 13:49 ` [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property Rakesh Kota
2026-05-18 13:59 ` sashiko-bot
2026-05-19 7:09 ` Rakesh Kota
2026-05-18 15:27 ` Krzysztof Kozlowski
2026-05-19 8:25 ` Rakesh Kota
2026-05-19 10:35 ` Krzysztof Kozlowski
2026-05-19 10:47 ` Konrad Dybcio
2026-05-19 10:49 ` Krzysztof Kozlowski
2026-05-21 7:13 ` Kamal Wadhwa
2026-05-21 7:20 ` Krzysztof Kozlowski
2026-05-21 8:46 ` Konrad Dybcio
2026-05-21 9:58 ` Krzysztof Kozlowski
2026-05-22 9:24 ` Konrad Dybcio
2026-05-22 10:32 ` Krzysztof Kozlowski
2026-05-22 10:34 ` Konrad Dybcio
2026-05-25 12:01 ` Rakesh Kota
2026-07-02 11:30 ` Rakesh Kota
2026-07-02 11:48 ` Krzysztof Kozlowski [this message]
2026-07-02 11:49 ` Dmitry Baryshkov
2026-05-21 12:38 ` Rakesh Kota
2026-05-21 23:34 ` Dmitry Baryshkov
2026-05-18 13:49 ` [PATCH 2/2] power: supply: qcom_battmgr: Add support batteryless boards as MAINS Rakesh Kota
2026-05-18 15:10 ` sashiko-bot
2026-05-19 6:55 ` Rakesh Kota
2026-05-18 14:36 ` [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Konrad Dybcio
2026-05-19 6:59 ` Rakesh Kota
2026-05-19 10:58 ` Konrad Dybcio
2026-05-21 12:28 ` Rakesh Kota
2026-05-21 22:56 ` Bjorn Andersson
2026-06-30 14:16 ` Konrad Dybcio
2026-07-02 11:17 ` Rakesh Kota
2026-07-02 11:28 ` Krzysztof Kozlowski
2026-07-03 9:13 ` Rakesh Kota
2026-07-03 9:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08ef6b3e-be83-4516-954d-dbdb68776df2@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rakesh.kota@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox