Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	jishnu.prakash@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com
Subject: Re: [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support
Date: Thu, 2 Jul 2026 13:28:35 +0200	[thread overview]
Message-ID: <5d5c693b-bd07-40a4-aea5-d9e1884aac50@kernel.org> (raw)
In-Reply-To: <20260702111737.2qtjcfskulav4usd@hu-kotarake-hyd.qualcomm.com>

On 02/07/2026 13:17, Rakesh Kota wrote:
> On Tue, Jun 30, 2026 at 04:16:13PM +0200, Konrad Dybcio wrote:
>> On 5/22/26 12:56 AM, Bjorn Andersson wrote:
>>> On Tue, May 19, 2026 at 12:29:38PM +0530, Rakesh Kota wrote:
>>>> On Mon, May 18, 2026 at 04:36:32PM +0200, Konrad Dybcio wrote:
>>>>> On 5/18/26 3:49 PM, Rakesh Kota wrote:
>>>>>> On batteryless boards powered by 12V DC adapters, registering the
>>>>>> power supply as BATTERY causes userspace to incorrectly trigger
>>>>>> battery power-saving sequences.
>>>>>
>>>>> Does battman really offer no way of differentiating whether a battery
>>>>> is *actually* present in such cases?
>>>>>
>>>>> What boards are affected?
>>>>>
>>>> Currently, batteryless support is only implemented for the
>>>> qcs6490-rb3gen2(Kodiak) board.
>>>>
>>>
>>> What do you mean?
>>>
>>> Are you saying that the pmic_glink firmware in Kodiak has a one-off hack
>>> that no other implementation of this firmware has?
>>>
>>> My Lenovo IdeaCentre (hamoa) doesn't have battery, what should I do now?
>>
>> I was going through my inbox.
>> This remains unanswered, and I don't see the discussion progressing
>> without resolving this.
>>
> To clarify — there is no platform-side hack involved. The Kodiak board
> has a batteryless variant, but the pmic_glink firmware provides no way
> to distinguish whether a battery is physically present or not. Since
> this can't be determined from firmware, we introduced a DT-based
> property to describe the hardware configuration explicitly.
> 
> This is not Kodiak-specific — any batteryless board, including hamoa,
> can use the same DT property to avoid incorrect BATTERY registration

Unfortunately the answer might be: fix your firmware. Since your
firmware is the interface and we do not expose battery in DT, then you
do not get additional properties. You made conscious design choice of
abstracting some things in the firmware, so you do control that part of
the software stack. If you make one choice, it might lead to other, like
rejecting such properties.

Best regards,
Krzysztof

  reply	other threads:[~2026-07-02 11:28 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 13:49 [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Rakesh Kota
2026-05-18 13:49 ` [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property Rakesh Kota
2026-05-18 13:59   ` sashiko-bot
2026-05-19  7:09     ` Rakesh Kota
2026-05-18 15:27   ` Krzysztof Kozlowski
2026-05-19  8:25     ` Rakesh Kota
2026-05-19 10:35       ` Krzysztof Kozlowski
2026-05-19 10:47         ` Konrad Dybcio
2026-05-19 10:49           ` Krzysztof Kozlowski
2026-05-21  7:13         ` Kamal Wadhwa
2026-05-21  7:20           ` Krzysztof Kozlowski
2026-05-21  8:46             ` Konrad Dybcio
2026-05-21  9:58               ` Krzysztof Kozlowski
2026-05-22  9:24                 ` Konrad Dybcio
2026-05-22 10:32                   ` Krzysztof Kozlowski
2026-05-22 10:34                     ` Konrad Dybcio
2026-05-25 12:01                   ` Rakesh Kota
2026-07-02 11:30                     ` Rakesh Kota
2026-07-02 11:48                       ` Krzysztof Kozlowski
2026-07-02 11:49                       ` Dmitry Baryshkov
2026-05-21 12:38               ` Rakesh Kota
2026-05-21 23:34           ` Dmitry Baryshkov
2026-05-18 13:49 ` [PATCH 2/2] power: supply: qcom_battmgr: Add support batteryless boards as MAINS Rakesh Kota
2026-05-18 15:10   ` sashiko-bot
2026-05-19  6:55     ` Rakesh Kota
2026-05-18 14:36 ` [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Konrad Dybcio
2026-05-19  6:59   ` Rakesh Kota
2026-05-19 10:58     ` Konrad Dybcio
2026-05-21 12:28       ` Rakesh Kota
2026-05-21 22:56     ` Bjorn Andersson
2026-06-30 14:16       ` Konrad Dybcio
2026-07-02 11:17         ` Rakesh Kota
2026-07-02 11:28           ` Krzysztof Kozlowski [this message]
2026-07-03  9:13             ` Rakesh Kota
2026-07-03  9:16               ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d5c693b-bd07-40a4-aea5-d9e1884aac50@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rakesh.kota@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox