From: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
David Collins <david.collins@oss.qualcomm.com>,
Subbaraman Narayanamurthy
<subbaraman.narayanamurthy@oss.qualcomm.com>,
Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
Maulik Shah <maulik.shah@oss.qualcomm.com>,
kernel@oss.qualcomm.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] pinctrl: qcom: spmi-gpio: Rearchitect for flexible group support
Date: Mon, 1 Jun 2026 13:17:06 +0800 [thread overview]
Message-ID: <155c7b48-6fa6-4f25-8b0f-4e9081d5fadf@oss.qualcomm.com> (raw)
In-Reply-To: <20260530-fervent-snobbish-silkworm-24ddae@quoll>
On 5/30/2026 6:31 PM, Krzysztof Kozlowski wrote:
> On Thu, May 28, 2026 at 06:05:37PM -0700, Fenglin Wu wrote:
>> Currently, the driver treats each pin as a group, and every pin or
>> group can function correctly in all existing functions. However,
>> this approach is no longer valid since some PMIC pins only operate
>> together in specific functions, which are limited to certain GPIO
>> groups. For example, in pmh0101, the level-shifter function is
>> supported only between GPIO pairs like GPIO11/12, GPIO13/14,
>> GPIO15/16, and GPIO17/18.
>>
>> To better accommodate these new functions and restrict GPIOs to
>> those that support them, rearchitect the driver to enable flexible
>> pinctrl group configurations by utilizing the generic pinctrl group
>> and function APIs.
>>
>> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
>> ---
>> drivers/pinctrl/qcom/Kconfig | 2 +
>> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 377 +++++++++++++++++++++----------
> And now make this built-in and RPMH as module, then build it. Does
> it build?
Thanks. I missed to add the dependency in patch4 which really adds the
rpmh control. I will update the Kconfig to make it depends on rpmh and
cmd-db drivers.
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-06-01 5:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 1:05 [PATCH v2 0/4] pinctrl: qcom: spmi-gpio: Add bidirectional level-shifter function support Fenglin Wu
2026-05-29 1:05 ` [PATCH v2 1/4] soc: qcom: rpmh: Allow non-child devices to issue write commands Fenglin Wu
2026-05-29 1:45 ` sashiko-bot
2026-06-01 8:48 ` Bartosz Golaszewski
2026-06-01 13:37 ` Dmitry Baryshkov
2026-06-02 7:29 ` Fenglin Wu
2026-06-04 2:02 ` Fenglin Wu
2026-06-07 21:21 ` Dmitry Baryshkov
2026-06-09 1:28 ` Fenglin Wu
2026-06-11 10:36 ` Konrad Dybcio
2026-06-12 0:27 ` Dmitry Baryshkov
2026-06-18 6:39 ` Fenglin Wu
2026-06-30 14:28 ` Konrad Dybcio
2026-06-30 14:37 ` Mark Brown
2026-07-01 2:43 ` Fenglin Wu
2026-07-01 11:33 ` Mark Brown
2026-05-29 1:05 ` [PATCH v2 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add level-shifter function Fenglin Wu
2026-05-29 2:01 ` sashiko-bot
2026-05-30 10:29 ` Krzysztof Kozlowski
2026-06-01 5:00 ` Fenglin Wu
2026-06-01 11:30 ` Krzysztof Kozlowski
2026-06-02 7:14 ` Fenglin Wu
2026-05-29 1:05 ` [PATCH v2 3/4] pinctrl: qcom: spmi-gpio: Rearchitect for flexible group support Fenglin Wu
2026-05-30 10:31 ` Krzysztof Kozlowski
2026-06-01 5:17 ` Fenglin Wu [this message]
2026-05-29 1:05 ` [PATCH v2 4/4] pinctrl: qcom: spmi-gpio: Add level-shifter function support Fenglin Wu
2026-05-29 3:15 ` sashiko-bot
2026-05-29 20:25 ` [PATCH v2 0/4] pinctrl: qcom: spmi-gpio: Add bidirectional " Linus Walleij
2026-06-01 5:18 ` Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155c7b48-6fa6-4f25-8b0f-4e9081d5fadf@oss.qualcomm.com \
--to=fenglin.wu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david.collins@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maulik.shah@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=subbaraman.narayanamurthy@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox