public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Leith Bade <leith@bade.nz>
Cc: frank-w@public-files.de, linux-mediatek@lists.infradead.org,
	 matthias.bgg@gmail.com, krzk+dt@kernel.org,
	didi.debian@cknow.org,  devicetree@vger.kernel.org,
	angelogioacchino.delregno@collabora.com,
	 linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org
Subject: Re: [PATCH 0/4] fix up pin definitions for BPI-R3 board
Date: Thu, 27 Jun 2024 08:48:49 -0600	[thread overview]
Message-ID: <171949936716.3312392.7734746271986363667.robh@kernel.org> (raw)
In-Reply-To: <20240627075856.2314804-1-leith@bade.nz>


On Thu, 27 Jun 2024 17:58:52 +1000, Leith Bade wrote:
> This is my first patch submission to Linux so I apologise in advance for
> any mistakes.
> 
> These changes were motivated by a pin conflict with the PCIe M.2 connector
> and the push buttons. As a result I decided go work through all 100 GPIO
> pins using the public board schematics. As I need to acquire a M.2 SSD to
> test the PCIe pin change that patch is not included in this series yet.
> 
> Working though the pins I noticed a bug with with the MT7531 chip's reset
> line which was on the wrong GPIO. Since it was conflicting with the boot
> mode switch input GPIO pins I looked into ways to document the use of
> those pins with the switch. I ended up choosing a gpio-hog, but please
> let me know if there is a better alternative.
> 
> I also added some missing pin groups for some of the built-in SoC devices
> to clearly document the use of those GPIO pins.
> 
> I have actually written up a gpio-line-names list give all the pins
> names to match their usage on this board. If there is interest in this
> I can submit this as an additional patch. I see only some MT8xxx devices
> in the mediatek directory have a gpio-line-names so I wasn't sure if I
> should add it.
> 
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y mediatek/mt7986a-bananapi-bpi-r3.dtb' for 20240627075856.2314804-1-leith@bade.nz:

arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pinctrl@1001f000: 'boot-mode-hog' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt7986-pinctrl.yaml#






  parent reply	other threads:[~2024-06-27 14:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27  7:58 [PATCH 0/4] fix up pin definitions for BPI-R3 board Leith Bade
2024-06-27  7:58 ` [PATCH 1/4] arm64: dts: mediatek: mt7986: fix the switch reset line on BPI-R3 Leith Bade
2024-07-30  9:18   ` AngeloGioacchino Del Regno
2024-06-27  7:58 ` [PATCH 2/4] arm64: dts: mediatek: mt7986: add gpio-hog for boot mode switch " Leith Bade
2024-07-03 11:39   ` kernel test robot
2024-07-04  7:41     ` Krzysztof Kozlowski
2024-07-04  8:56       ` Philip Li
2024-06-27  7:58 ` [PATCH 3/4] arm64: dts: mediatek: mt7986: add missing pin groups to BPI-R3 Leith Bade
2024-06-27  7:58 ` [PATCH 4/4] arm64: dts: mediatek: mt7986: add missing UART1 CTS/RTS pins in BPI-R3 Leith Bade
2024-07-30  9:18   ` AngeloGioacchino Del Regno
2024-06-27 14:48 ` Rob Herring (Arm) [this message]
2024-06-29 23:06   ` [PATCH 0/4] fix up pin definitions for BPI-R3 board Leith Bade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171949936716.3312392.7734746271986363667.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=frank-w@public-files.de \
    --cc=krzk+dt@kernel.org \
    --cc=leith@bade.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox