From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Leith Bade <leith@bade.nz>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, frank-w@public-files.de
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, didi.debian@cknow.org
Subject: Re: [PATCH 4/4] arm64: dts: mediatek: mt7986: add missing UART1 CTS/RTS pins in BPI-R3
Date: Tue, 30 Jul 2024 11:18:37 +0200 [thread overview]
Message-ID: <b5b4c23b-e5d5-4266-9df1-28bc731c469e@collabora.com> (raw)
In-Reply-To: <20240627075856.2314804-5-leith@bade.nz>
Il 27/06/24 09:58, Leith Bade ha scritto:
> The current definition of the uart1_pins pin group does not include the
> CTS and RTS pins that are available on header CON1.
>
> In the public schematic for the BPI-R3 (titled "BPI-R3-MT7986A",
> revision "V1.1", sheet 4), the UART1_RTS and UART1_CTS pins are connected
> via nets to the connector CON1 (sheet 14) UART0-RTS and UART0-CTS pins.
> The datasheet does not show these nets as connected to anything else.
>
> These pins can be configured for either UART1 or as a GPIO, with no other
> alternate usage listed in the pinctrl driver. By changing the pin group
> definition from uart1_rx_tx to uart1 the additional RTS and CTS pins are
> included.
>
> Signed-off-by: Leith Bade <leith@bade.nz>
Fixes tag please, after which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cheers,
Angelo
next prev parent reply other threads:[~2024-07-30 9:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 7:58 [PATCH 0/4] fix up pin definitions for BPI-R3 board Leith Bade
2024-06-27 7:58 ` [PATCH 1/4] arm64: dts: mediatek: mt7986: fix the switch reset line on BPI-R3 Leith Bade
2024-07-30 9:18 ` AngeloGioacchino Del Regno
2024-06-27 7:58 ` [PATCH 2/4] arm64: dts: mediatek: mt7986: add gpio-hog for boot mode switch " Leith Bade
2024-07-03 11:39 ` kernel test robot
2024-07-04 7:41 ` Krzysztof Kozlowski
2024-07-04 8:56 ` Philip Li
2024-06-27 7:58 ` [PATCH 3/4] arm64: dts: mediatek: mt7986: add missing pin groups to BPI-R3 Leith Bade
2024-06-27 7:58 ` [PATCH 4/4] arm64: dts: mediatek: mt7986: add missing UART1 CTS/RTS pins in BPI-R3 Leith Bade
2024-07-30 9:18 ` AngeloGioacchino Del Regno [this message]
2024-06-27 14:48 ` [PATCH 0/4] fix up pin definitions for BPI-R3 board Rob Herring (Arm)
2024-06-29 23:06 ` Leith Bade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5b4c23b-e5d5-4266-9df1-28bc731c469e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=frank-w@public-files.de \
--cc=krzk+dt@kernel.org \
--cc=leith@bade.nz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox