public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Leith Bade <leith@bade.nz>
To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
	frank-w@public-files.de
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, didi.debian@cknow.org,
	Leith Bade <leith@bade.nz>
Subject: [PATCH 1/4] arm64: dts: mediatek: mt7986: fix the switch reset line on BPI-R3
Date: Thu, 27 Jun 2024 17:58:53 +1000	[thread overview]
Message-ID: <20240627075856.2314804-2-leith@bade.nz> (raw)
In-Reply-To: <20240627075856.2314804-1-leith@bade.nz>

The current GPIO definition for the MT7531 switch reset line incorrectly
specifies a pin GPIO_0 (GPIO5) that is connected to the boot mode
selection DIP switch (SW1).

In the public schematic for the BPI-R3 (titled "BPI-R3-MT7986A",
revision "V1.1", sheet 4), the SPI1_CS (GPIO32) pin of the MT7986 (U1E)
is connected to the GbE_RESET net.

Frank Wunderlich has told me, via the Banana Pi forum, that this GbE_RESET
net connects to the MT7531 reset line in the private part of the shematic
he has a copy of.

Signed-off-by: Leith Bade <leith@bade.nz>
---
 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
index ed79ad1ae871..951612ea1e66 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
@@ -206,7 +206,7 @@ switch: switch@31 {
 		interrupt-controller;
 		#interrupt-cells = <1>;
 		interrupts-extended = <&pio 66 IRQ_TYPE_LEVEL_HIGH>;
-		reset-gpios = <&pio 5 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&pio 32 GPIO_ACTIVE_HIGH>;
 	};
 };
 
-- 
2.25.1


  reply	other threads:[~2024-06-27  7:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27  7:58 [PATCH 0/4] fix up pin definitions for BPI-R3 board Leith Bade
2024-06-27  7:58 ` Leith Bade [this message]
2024-07-30  9:18   ` [PATCH 1/4] arm64: dts: mediatek: mt7986: fix the switch reset line on BPI-R3 AngeloGioacchino Del Regno
2024-06-27  7:58 ` [PATCH 2/4] arm64: dts: mediatek: mt7986: add gpio-hog for boot mode switch " Leith Bade
2024-07-03 11:39   ` kernel test robot
2024-07-04  7:41     ` Krzysztof Kozlowski
2024-07-04  8:56       ` Philip Li
2024-06-27  7:58 ` [PATCH 3/4] arm64: dts: mediatek: mt7986: add missing pin groups to BPI-R3 Leith Bade
2024-06-27  7:58 ` [PATCH 4/4] arm64: dts: mediatek: mt7986: add missing UART1 CTS/RTS pins in BPI-R3 Leith Bade
2024-07-30  9:18   ` AngeloGioacchino Del Regno
2024-06-27 14:48 ` [PATCH 0/4] fix up pin definitions for BPI-R3 board Rob Herring (Arm)
2024-06-29 23:06   ` Leith Bade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240627075856.2314804-2-leith@bade.nz \
    --to=leith@bade.nz \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=frank-w@public-files.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox